| Summary: | Move 'Last patron' button inside of the 'breadcrumb' bar | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Staff interface | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | eric.begin, gmcharlt, hickeyhe, lucas, oleonard, wizzyrea |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 20312 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 21245: Move 'Last patron' button into 'breadcrumb' bar
Bug 21245: Move 'Last patron' button into 'breadcrumb' bar |
||
|
Description
Martin Renvoize (ashimema)
2018-08-18 07:36:56 UTC
This looks like it has been fixed in master, setting to resolved. This doesn't look like it's the case to me. Created attachment 89426 [details] [review] Bug 21245: Move 'Last patron' button into 'breadcrumb' bar This patch moved the 'Last patron' button introduced in bug 20312 inline with the breadcrumb bar from floating above it. I'm sure there must be a nicer way of doing this.. Owen? I really think this ought to appear up in the top nav, maybe between Cart and More? Well, let me explain perhaps - I know of a library that implemented something like this on Koha with the last 10 borrowers, and they put the drop down for that in the upper nav menu. It was very handy, I wish they would have submitted it Anyway, I do think it'd be better in a slightly more visible spot. I mostly just don't like they way it currently feels detached and hovers above the breadcrumb bar.. I'm happy to take suggestions as to better locations :) To test : - Apply the patch - Make sure your showLastPatron syspref is set to Show - Update the CSS using 'yarn build' command to update the CSS from the SCSS - Access a patron account - Go on the home page You should now see the Last patron's button. Created attachment 93722 [details] [review] Bug 21245: Move 'Last patron' button into 'breadcrumb' bar This patch moved the 'Last patron' button introduced in bug 20312 inline with the breadcrumb bar from floating above it. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work! Pushed to master for 19.11.00 |