| Summary: | Fix COinS carp in MARC details page on unknown record | ||
|---|---|---|---|
| Product: | Koha | Reporter: | paxed <pasi.kallinen> |
| Component: | Staff interface | Assignee: | paxed <pasi.kallinen> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, m.de.rooy, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 21248: Fix COinS carp in MARC details page on unknown record
Bug 21248: Fix COinS carp in MARC details page on unknown record Bug 21248: Fix COinS carp in MARC details page on unknown record |
||
|
Description
paxed
2018-08-20 04:29:24 UTC
Created attachment 78011 [details] [review] Bug 21248: Fix COinS carp in MARC details page on unknown record Looking up a nonexistent record in the MARC details -page causes the COinS to carp. The fix is trivial, just move the COinS call couple lines, after the record existence check. Created attachment 78451 [details] [review] Bug 21248: Fix COinS carp in MARC details page on unknown record Looking up a nonexistent record in the MARC details -page causes the COinS to carp. The fix is trivial, just move the COinS call couple lines, after the record existence check. TEST PLAN --------- 1) reset_all for kohadevbox 2) log in to staff client - admin/admin 3) search catalogue for green 4) tweak the top URL to have a bad biblionumber (eg. 9999) 5) cat /var/log/koha/kohadev/plack-err.log -- floody! with errors. 6) echo | sudo tee /var/log/koha/kohadev/plack-err.log 7) restart_all 8) repeat steps 2 through 5. -- just nice starting messages, not floody. 9) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 78644 [details] [review] Bug 21248: Fix COinS carp in MARC details page on unknown record Looking up a nonexistent record in the MARC details -page causes the COinS to carp. The fix is trivial, just move the COinS call couple lines, after the record existence check. TEST PLAN --------- 1) reset_all for kohadevbox 2) log in to staff client - admin/admin 3) search catalogue for green 4) tweak the top URL to have a bad biblionumber (eg. 9999) 5) cat /var/log/koha/kohadev/plack-err.log -- floody! with errors. 6) echo | sudo tee /var/log/koha/kohadev/plack-err.log 7) restart_all 8) repeat steps 2 through 5. -- just nice starting messages, not floody. 9) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.04 Pushed to 17.11.x for 17.11.10 |