| Summary: | X_FORWARDED_PROTO header should be set in apache | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Packaging | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy, martin.renvoize, mirko, nick, ulrich.kleiber |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19799 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 21267: Set X-FORWARDED-PROTO https if required
Bug 21267: Set X-FORWARDED-PROTO https if required Bug 21267: Set X-FORWARDED-PROTO https if required |
||
|
Description
Tomás Cohen Arazi (tcohen)
2018-08-24 13:39:49 UTC
Created attachment 78132 [details] [review] Bug 21267: Set X-FORWARDED-PROTO https if required This patch makes the apache configuration for the reverse proxy (required for Plack) so it sets the X-FORWARDED-PROTO header correctly for Plack::Middleware::ReverseProxy to use it. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 78133 [details] [review] Bug 21267: Set X-FORWARDED-PROTO https if required This patch makes the apache configuration for the reverse proxy (required for Plack) so it sets the X-FORWARDED-PROTO header correctly for Plack::Middleware::ReverseProxy to use it. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> QA: Looking here now Created attachment 78321 [details] [review] Bug 21267: Set X-FORWARDED-PROTO https if required This patch makes the apache configuration for the reverse proxy (required for Plack) so it sets the X-FORWARDED-PROTO header correctly for Plack::Middleware::ReverseProxy to use it. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Since we actually resolve 19799 now (Changing language on OPAC redirects back to homepage), I will move that code to a new enh report. Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.04 Pushed to 17.11.x for 17.11.10 |