| Summary: | Ordered/spent lists should use prices including tax for calculations | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
Corrects the prices shown on the ordered/spent lists for each fund in acquisitions to show the price with taxes included. This will make the total shown on these pages match the total shown in the table on the acq start and fund pages.
|
Version(s) released in: | |
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 21427 | ||
| Attachments: |
Bug 21282: Sync ordered and spent values with acqui home
Bug 21282: Sync ordered and spent values with acqui home Bug 21282: Sync ordered and spent values with acqui home Bug 21282: Sync ordered and spent values with acqui home |
||
|
Description
Katrin Fischer
2018-08-28 21:56:02 UTC
Created attachment 78293 [details] [review] Bug 21282: Sync ordered and spent values with acqui home The order list for each fund calculates using the ecost tax excl., but it should be tax incl. At the moment this means that the sum on the start page table and the order list don't match up. Test plan: - Create and receive orders - Values on acqui home and ordered/spent should be the same Patch doesn't apply (should have a html filter?) and should be formatted. Currently displays with more than 2 decimals on ordered list. Was not sure why it conflicted already. Jonathan, could you have another look here? Created attachment 81003 [details] [review] Bug 21282: Sync ordered and spent values with acqui home The order list for each fund calculates using the ecost tax excl., but it should be tax incl. At the moment this means that the sum on the start page table and the order list don't match up. Test plan: - Create and receive orders - Values on acqui home and ordered/spent should be the same Created attachment 81794 [details] [review] Bug 21282: Sync ordered and spent values with acqui home The order list for each fund calculates using the ecost tax excl., but it should be tax incl. At the moment this means that the sum on the start page table and the order list don't match up. Test plan: - Create and receive orders - Values on acqui home and ordered/spent should be the same Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 82252 [details] [review] Bug 21282: Sync ordered and spent values with acqui home The order list for each fund calculates using the ecost tax excl., but it should be tax incl. At the moment this means that the sum on the start page table and the order list don't match up. Test plan: - Create and receive orders - Values on acqui home and ordered/spent should be the same Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I'm happy to pass qa on this. It brings more consistency and reducing confusion and there are no regressions that I can see. I think a note on the release notes wouldn't go amiss however.. as it could be a surprising/confusing change. (In reply to Martin Renvoize from comment #8) > I think a note on the release notes wouldn't go amiss however.. as it could > be a surprising/confusing change. I think it's a clear bug - the total on the acq home page is correct, the total on these pages is wrong. There is a clear mismatch that needs to be fixed. Totally agree, thanks for adding the release note to clarify the change/correction. Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.06 I'm not sure it should be pushed to 17.11.x. The change of display may not be wanted on a very stable branch. Hi Frido, the amounts are wrong - this is a bug fix, not for prettiness! :) The fields in the db are all there in 17.11 so I push. Pushed to 17.11.x for 17.11.13 |