| Summary: | Select2 broken on high dpi screens | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Templates | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Owen Leonard <oleonard> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 21285: Add missing select2x2.png file
Bug 21285: Add missing select2x2.png file Bug 21285: Add missing select2x2.png file |
||
|
Description
Tomás Cohen Arazi (tcohen)
2018-08-29 16:45:40 UTC
Created attachment 78273 [details] [review] Bug 21285: Add missing select2x2.png file This file is part of the Select2 jquery plugin, but wasn't added when the use of the plugin was introduced in Koha. To test: - On a high DPI screen (retina mac?) on Chrome or Safari - Edit an item => FAIL: dropdowns using Select2 (like 'Shelving location') don't display the icons (down arrow and cross) and a default value is wrongly selected => FAIL: the inspector says the requested select2x2.png file returned a 400 error. - Apply this patch - Reload the edit page => SUCCESS: Things display correctly! Dropdowns without selected values by default! => SUCCESS: No errors fetching select2x2.png - Sign off :-D Created attachment 78333 [details] [review] Bug 21285: Add missing select2x2.png file This file is part of the Select2 jquery plugin, but wasn't added when the use of the plugin was introduced in Koha. To test: - On a high DPI screen (retina mac?) on Chrome or Safari - Edit an item => FAIL: dropdowns using Select2 (like 'Shelving location') don't display the icons (down arrow and cross) and a default value is wrongly selected => FAIL: the inspector says the requested select2x2.png file returned a 400 error. - Apply this patch - Reload the edit page => SUCCESS: Things display correctly! Dropdowns without selected values by default! => SUCCESS: No errors fetching select2x2.png - Sign off :-D Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> No regression on a non-high dpi screen Created attachment 78616 [details] [review] Bug 21285: Add missing select2x2.png file This file is part of the Select2 jquery plugin, but wasn't added when the use of the plugin was introduced in Koha. To test: - On a high DPI screen (retina mac?) on Chrome or Safari - Edit an item => FAIL: dropdowns using Select2 (like 'Shelving location') don't display the icons (down arrow and cross) and a default value is wrongly selected => FAIL: the inspector says the requested select2x2.png file returned a 400 error. - Apply this patch - Reload the edit page => SUCCESS: Things display correctly! Dropdowns without selected values by default! => SUCCESS: No errors fetching select2x2.png - Sign off :-D Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.04 Pushed to 17.11.x for 17.11.10 |