|
Description
Blou
2018-08-30 14:30:26 UTC
Created attachment 78311 [details] [review] Bug 21291: request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar When on a detailed record in the intranet, any click on the sidebar will lead you to another page with the same sidebar EXCEPT for "Article requests". When clicking on article requests, you get a new sidebar without MARC Labeled MARC ISBD This fix adds the required C4::Biblio::enabled_staff_search_views that loads the required hash with the permissions. TEST 0) login with a user having all rights 1) go to any detailed notices, notice the sidebar on the left 2) click on MARC 3) notice the sidebar is the same in the new page 4) click on Request articles 5) notice the missing labels on the sidebar 6) apply patch, redo steps Patch works as described, but you missed the tab "Subscription(s)" which also disappears when we're on "Article request" + "Holds" +"Checkout history" + "Modification logs" tabs. Do you want to fix it too, or should I open a new report ? "In Discussion" asks for more opinions, better to use "Failed QA" for questions to the developer. Oups... sorry Katrin, and thanks for the advice ! Created attachment 79952 [details] [review] Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar The subscriptionsnumber is required in biblio-view-menu.inc to display the Subscription(s) tab. In detail.pl, if you click any of Hold(s) Article requests Checkout history Modification log you lose the Subscription(s) tab. This patch fixes the display by having each feature script generate that value to be passed to the UI. I keep this separated from the first patch since it's not exactly the same issue, and the solution might not please. Created attachment 79958 [details] [review] Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar The subscriptionsnumber is required in biblio-view-menu.inc to display the Subscription(s) tab. In detail.pl, if you click any of Hold(s) Article requests Checkout history Modification log you lose the Subscription(s) tab. This patch fixes the display by having each feature script generate that value to be passed to the UI. I keep this separated from the first patch since it's not exactly the same issue, and the solution might not please. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Sorry, patch doesn't apply - can you have a look please? sloth:/usr/local/vagrant/kohaclone_master (30-21291-missing-navigation) $ git b apply 21291 Bug 21291 - request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar 79958 - Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar error: sha1 information is lacking or useless (circ/request-article.pl). error: could not build fake ancestor Patch failed at 0001 Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". The first patch had been obsoleted. Once put back, it all applies without problem. I noticed a couple of things while working on Bug 21492 I noticed a couple of issues with this: - Missing subscriptions tab on the labeled MARC view (catalogue/labeledMARCdetail.pl) - Missing subscriptions tab on the stock rotation page (catalogue/stockrotation.pl) - The subscriptionsnumber variable being passed to the view log template is not a number as it is on other page. With Bug 21492 applied the variable is output as "Object." Created attachment 80369 [details] [review] Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar The subscriptionsnumber is required in biblio-view-menu.inc to display the Subscription(s) tab. In detail.pl, if you click any of Labeled MARC (you need to set the syspref viewLabeledMARC) Hold(s) Article requests Checkout history Modification log Rota (you need to set the syspref StockRotation) you lose the Subscription(s) tab. This patch fixes the display by having each feature script generate that value to be passed to the UI. I keep this separated from the first patch since it's not exactly the same issue, and the solution might not please. Created attachment 80401 [details] [review] Bug 21291: request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar When on a detailed record in the intranet, any click on the sidebar will lead you to another page with the same sidebar EXCEPT for "Article requests". When clicking on article requests, you get a new sidebar without MARC Labeled MARC ISBD This fix adds the required C4::Biblio::enabled_staff_search_views that loads the required hash with the permissions. TEST 0) login with a user having all rights 1) go to any detailed notices, notice the sidebar on the left 2) click on MARC 3) notice the sidebar is the same in the new page 4) click on Request articles 5) notice the missing labels on the sidebar 6) apply patch, redo steps Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 80402 [details] [review] Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar The subscriptionsnumber is required in biblio-view-menu.inc to display the Subscription(s) tab. In detail.pl, if you click any of Labeled MARC (you need to set the syspref viewLabeledMARC) Hold(s) Article requests Checkout history Modification log Rota (you need to set the syspref StockRotation) you lose the Subscription(s) tab. This patch fixes the display by having each feature script generate that value to be passed to the UI. I keep this separated from the first patch since it's not exactly the same issue, and the solution might not please. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 80427 [details] [review] Bug 21291: request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar When on a detailed record in the intranet, any click on the sidebar will lead you to another page with the same sidebar EXCEPT for "Article requests". When clicking on article requests, you get a new sidebar without MARC Labeled MARC ISBD This fix adds the required C4::Biblio::enabled_staff_search_views that loads the required hash with the permissions. TEST 0) login with a user having all rights 1) go to any detailed notices, notice the sidebar on the left 2) click on MARC 3) notice the sidebar is the same in the new page 4) click on Request articles 5) notice the missing labels on the sidebar 6) apply patch, redo steps Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 80428 [details] [review] Bug 21291: (follow-up) Pass subscriptionsnumber to all tools in staff detail's sidebar The subscriptionsnumber is required in biblio-view-menu.inc to display the Subscription(s) tab. In detail.pl, if you click any of Labeled MARC (you need to set the syspref viewLabeledMARC) Hold(s) Article requests Checkout history Modification log Rota (you need to set the syspref StockRotation) you lose the Subscription(s) tab. This patch fixes the display by having each feature script generate that value to be passed to the UI. I keep this separated from the first patch since it's not exactly the same issue, and the solution might not please. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.05 For 17.11.x I prefer not to change display of oldstable branch |