Summary: | "More lists" screen missing "Select an Existing list" fieldset when all lists are public | ||
---|---|---|---|
Product: | Koha | Reporter: | Barton Chittenden <barton> |
Component: | Lists | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | arattler, caroline.cyr-la-rose, fridolin.somers, jonathan.druart, julian.maurice, m.de.rooy, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 17886 | ||
Bug Blocks: | |||
Attachments: |
Bug 21297: Display public lists to existing lists when adding a new item
Bug 21297: Display public lists to existing lists when adding a new item |
Description
Barton Chittenden
2018-08-30 22:54:38 UTC
Caused by commit c089df3f3b45782516b63d22c34bc265c667dd35 Bug 17886: Don't show option to add to existing list if there are no lists Created attachment 78829 [details] [review] Bug 21297: Display public lists to existing lists when adding a new item If there are no private lists the public lists are not displayed. Test plan: 1) Add 10 public lists (This is when the 'More lists' menu item becomes view-able) 2) Select an item 3) Click Add to list 4) Select 'More Lists' menu item 5) Note that 'Select an existing list' is an available option Note for QA: The logic is correct OPAC side. The test should say add *more than* 10 lists. The "More lists" option only appeared after I added my 11th list. But otherwise, the patch works :) Created attachment 79292 [details] [review] Bug 21297: Display public lists to existing lists when adding a new item If there are no private lists the public lists are not displayed. Test plan: 1) Add 10 public lists (This is when the 'More lists' menu item becomes view-able) 2) Select an item 3) Click Add to list 4) Select 'More Lists' menu item 5) Note that 'Select an existing list' is an available option Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.05. Pushed to 17.11.x for 17.11.11 |