Bug 21306

Summary: Update two-column templates with Bootstrap grid: Tags
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: martin.renvoize, nick, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 20654    
Attachments: Bug 21306: Update two-column templates with Bootstrap grid: Tags
Bug 21306: Update two-column templates with Bootstrap grid: Tags
Bug 21306: Update two-column templates with Bootstrap grid: Tags

Description Owen Leonard 2018-08-31 18:12:47 UTC
This patch will convert tags templates to use the Bootstrap grid:

 - tags/list.tt
 - tags/review.tt
Comment 1 Owen Leonard 2018-08-31 18:14:38 UTC
Created attachment 78357 [details] [review]
Bug 21306: Update two-column templates with Bootstrap grid: Tags

This patch modifies the tags management templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Tags
   - View list of tags
   - Click tag to view the list of titles tagged with that term
Comment 2 Dilan Johnpullé 2018-09-05 01:11:31 UTC
Created attachment 78429 [details] [review]
Bug 21306: Update two-column templates with Bootstrap grid: Tags

This patch modifies the tags management templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Tags
   - View list of tags
   - Click tag to view the list of titles tagged with that term

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Comment 3 Jonathan Druart 2018-09-15 21:51:03 UTC
Created attachment 78899 [details] [review]
Bug 21306: Update two-column templates with Bootstrap grid: Tags

This patch modifies the tags management templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Tags
   - View list of tags
   - Click tag to view the list of titles tagged with that term

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Nick Clemens (kidclamp) 2018-09-16 18:23:15 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize (ashimema) 2018-09-17 14:35:04 UTC
Enhancement, will not be backported to 18.05.x series.