Bug 21308

Summary:	Show the search filters used on the search results page for acquisitions history searches
Product:	Koha	Reporter:	Barton Chittenden <barton>
Component:	Acquisitions	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	enhancement
Priority:	P5 - low	CC:	genevieve.beaudry, josef.moravec, martin.renvoize, nick, severine.queune
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:	This enhancement modifies the orders search results page so that the search form appears in the sidebar. This allows the user to view and re-use their search parameters.	Version(s) released in:	19.05.00
Circulation function:
Attachments:	Screenshot of search results, search for Title 'test' Bug 21308: Results from order search do not show the search parameters Bug 21308: Results from order search do not show the search parameters Bug 21308: Results from order search do not show the search parameters Bug 21308: Results from order search do not show the search parameters

Description Barton Chittenden 2018-08-31 23:17:28 UTC

A report from one of our partner libraries:

"It would be nice if the system told us what our search was.
We are often interrupted and then come back and have to get back
into our previous work flow. ... it would be nice to see the search
parameter explicitly shown in the breadcrumb trail - or somewhere"

The breadcrumb trail showed

Home › Acquisitions › Orders search › Search results

... and there was no indication of what had been searched for in the URL, or anywhare on the page (aside from implicitly in the returned results).

I ran several searches from cgi-bin/koha/acqui/histsearch.pl myself, and confirmed this.

To re-create:

1) Navigate to Home › Acquisitions
2) Click on 'Orders Search' under the masthead search bar
3) Search for a title and click 'Submit'
4) Run a browser search for the the title, note that it appears only in the results.

Comment 1 Barton Chittenden 2018-08-31 23:18:20 UTC

Created attachment 78359 [details]
Screenshot of search results, search for Title 'test'

Comment 2 Owen Leonard 2019-02-22 13:34:36 UTC

Created attachment 85525 [details] [review]
Bug 21308: Results from order search do not show the search parameters

This patch modifies the orders search results page so that the search
form appears in the sidebar. This allows the user to view and re-use
their search parameters.

This patch also moves the "no search results" message to the top of the
page in a message box.

To test, apply the patch and go to Acquisitions -> Orders search.

 - Perform a search which will return results. In the sidebar you should
   see the full orders search form with your search parameters in the
   form fields.

 - Perform a search which will return no results. You should see the
   "Your search returned no results." message in a standard message
   dialog.

Comment 3 Josef Moravec 2019-02-25 14:19:29 UTC

I don't think it is signed off...

Comment 4 Bin Wen 2019-03-01 20:44:02 UTC

Created attachment 85913 [details] [review]
Bug 21308: Results from order search do not show the search parameters

This patch modifies the orders search results page so that the search
form appears in the sidebar. This allows the user to view and re-use
their search parameters.

This patch also moves the "no search results" message to the top of the
page in a message box.

To test, apply the patch and go to Acquisitions -> Orders search.

 - Perform a search which will return results. In the sidebar you should
   see the full orders search form with your search parameters in the
   form fields.

 - Perform a search which will return no results. You should see the
   "Your search returned no results." message in a standard message
   dialog.

Signed-off-by: Bin Wen <bin.wen@inlibro.com>

Comment 5 Josef Moravec 2019-03-04 14:56:40 UTC

(In reply to Bin from comment #4)
> 
> Signed-off-by: Bin Wen <bin.wen@inlibro.com>

Bin, you should also change status of report to "Signed off" when you are signing off.

Comment 6 ByWater Sandboxes 2019-04-16 15:10:10 UTC

Created attachment 88078 [details] [review]
Bug 21308: Results from order search do not show the search parameters

This patch modifies the orders search results page so that the search
form appears in the sidebar. This allows the user to view and re-use
their search parameters.

This patch also moves the "no search results" message to the top of the
page in a message box.

To test, apply the patch and go to Acquisitions -> Orders search.

 - Perform a search which will return results. In the sidebar you should
   see the full orders search form with your search parameters in the
   form fields.

 - Perform a search which will return no results. You should see the
   "Your search returned no results." message in a standard message
   dialog.

Signed-off-by: Bin Wen <bin.wen@inlibro.com>

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Comment 7 Séverine Queune 2019-04-16 15:11:21 UTC

Seems ok to me !

Comment 8 Katrin Fischer 2019-04-16 20:35:46 UTC

Created attachment 88114 [details] [review]
Bug 21308: Results from order search do not show the search parameters

This patch modifies the orders search results page so that the search
form appears in the sidebar. This allows the user to view and re-use
their search parameters.

This patch also moves the "no search results" message to the top of the
page in a message box.

To test, apply the patch and go to Acquisitions -> Orders search.

 - Perform a search which will return results. In the sidebar you should
   see the full orders search form with your search parameters in the
   form fields.

 - Perform a search which will return no results. You should see the
   "Your search returned no results." message in a standard message
   dialog.

Signed-off-by: Bin Wen <bin.wen@inlibro.com>

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 9 Katrin Fischer 2019-04-16 20:36:09 UTC

I like it!

Comment 10 Nick Clemens (kidclamp) 2019-04-19 14:54:08 UTC

Awesome work all!

Pushed to master for 19.05

Comment 11 Martin Renvoize (ashimema) 2019-04-26 14:02:00 UTC

Enhancement will not be backported to 18.11.x series.