| Summary: | Adding controlfields to the ACQ framework causes issues when adding to basket | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | christian.stelzenmueller, fridolin.somers, jonathan.druart, lucas, m.de.rooy, marjorie.barry-vila, paul.thornton |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24294 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.03
|
|
| Circulation function: | |||
| Bug Depends on: | 19289 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 21316: Handle control fields in the ACQ frameworks
Bug 21316: Handle control fields in the ACQ frameworks Bug 21316: Handle control fields in the ACQ frameworks Bug 21316: Handle control fields in the ACQ frameworks |
||
|
Description
Nick Clemens (kidclamp)
2018-09-05 12:55:45 UTC
Why would you want to do that? Before bug 19289 the ACQ framework was only used for items, now it is used to edit *few* fields of a bibliographic records when creating a new order. If you create ACQ from the default framework you will end up with a huge list of inputs/selects. Yes, you don't want all, just easy way to recreate You might want 001 or 003 though I agree 001/003 would be good! Also possible 008 if you want to have them show up correctly in publication year search (might make sense especially looking for new things). Created attachment 86114 [details] [review] Bug 21316: Handle control fields in the ACQ frameworks Test plan: Turn UseACQFrameworkForBiblioRecords on Add 003@ to the ACQ framework Create an order from an existing record => The 003 value will be displayed! It fixes the following error: Control fields (generally, just tags below 010) do not have subfields, use data() at /home/vagrant/kohaclone/acqui/neworderempty.pl line 293. Created attachment 91484 [details] [review] Bug 21316: Handle control fields in the ACQ frameworks Test plan: Turn UseACQFrameworkForBiblioRecords on Add 003@ to the ACQ framework Create an order from an existing record => The 003 value will be displayed! It fixes the following error: Control fields (generally, just tags below 010) do not have subfields, use data() at /home/vagrant/kohaclone/acqui/neworderempty.pl line 293. Signed-off-by: CS <christian.stelzenmueller@bsz-bw.de> Confirmed in master, but also in 18.11.06 Created attachment 91516 [details] [review] Bug 21316: Handle control fields in the ACQ frameworks Test plan: - Turn UseACQFrameworkForBiblioRecords on - Add 003@ to the ACQ framework - Create an order from an existing record => The 003 value will be displayed! It fixes the following error: Control fields (generally, just tags below 010) do not have subfields, use data() at /home/vagrant/kohaclone/acqui/neworderempty.pl line 293. Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Fixed the sign-off line, but as I helped with testing, it would be nice to get another set of QA eyes on this. Created attachment 91613 [details] [review] Bug 21316: Handle control fields in the ACQ frameworks Test plan: - Turn UseACQFrameworkForBiblioRecords on - Add 003@ to the ACQ framework - Create an order from an existing record => The 003 value will be displayed! It fixes the following error: Control fields (generally, just tags below 010) do not have subfields, use data() at /home/vagrant/kohaclone/acqui/neworderempty.pl line 293. Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.03 backported to 18.11.x for 18.11.09 |