| Summary: | process_message_queue.pl --type should take an argument | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Magnus Enger <magnus> |
| Component: | Command-line Utilities | Assignee: | Magnus Enger <magnus> |
| Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | cslone, fridolin.somers, jonathan.druart, josef.moravec, m.de.rooy, martin.renvoize, nick, robin |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 19955 | ||
| Bug Blocks: | 37075 | ||
| Attachments: |
Bug 21322 - process_message_queue.pl --type should take an argument
Bug 21322: process_message_queue.pl --type should take an argument Bug 21322: process_message_queue.pl --type should take an argument Bug 21322: process_message_queue.pl --type should take an argument |
||
Created attachment 78476 [details] [review] Bug 21322 - process_message_queue.pl --type should take an argument The help for this script says: -t --type: If supplied, only processes this type of message ( email, sms ) Currently, the type argument is set up wrong, so it does not look for an argument. This patch fixes that. To test, run this command (should work in kohadevbox) or something similar: $ sudo koha-shell -c "perl \ /home/vagrant/kohaclone/misc/cronjobs/process_message_queue.pl -v \ --type=sms" kohadev This should give the following error: "Option type does not take an argument". Apply the patch and run the same command again. This should not give an error. Created attachment 78492 [details] [review] Bug 21322: process_message_queue.pl --type should take an argument The help for this script says: -t --type: If supplied, only processes this type of message ( email, sms ) Currently, the type argument is set up wrong, so it does not look for an argument. This patch fixes that. To test, run this command (should work in kohadevbox) or something similar: $ sudo koha-shell -c "perl \ /home/vagrant/kohaclone/misc/cronjobs/process_message_queue.pl -v \ --type=sms" kohadev This should give the following error: "Option type does not take an argument". Apply the patch and run the same command again. This should not give an error. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Magnus: Please fix: From: Your Full Name <magnus@libriotech.no> Created attachment 79406 [details] [review] Bug 21322: process_message_queue.pl --type should take an argument The help for this script says: -t --type: If supplied, only processes this type of message ( email, sms ) Currently, the type argument is set up wrong, so it does not look for an argument. This patch fixes that. To test, run this command (should work in kohadevbox) or something similar: $ sudo koha-shell -c "perl \ /home/vagrant/kohaclone/misc/cronjobs/process_message_queue.pl -v \ --type=sms" kohadev This should give the following error: "Option type does not take an argument". Apply the patch and run the same command again. This should not give an error. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Author info should be fixed now. Thanks for noticing! Created attachment 79847 [details] [review] Bug 21322: process_message_queue.pl --type should take an argument The help for this script says: -t --type: If supplied, only processes this type of message ( email, sms ) Currently, the type argument is set up wrong, so it does not look for an argument. This patch fixes that. To test, run this command (should work in kohadevbox) or something similar: $ sudo koha-shell -c "perl \ /home/vagrant/kohaclone/misc/cronjobs/process_message_queue.pl -v \ --type=sms" kohadev This should give the following error: "Option type does not take an argument". Apply the patch and run the same command again. This should not give an error. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.05 Pushed to 17.11.x for 17.11.11 |
If you run process_message_queue.pl -h you get this, among other things: -t --type: If supplied, only processes this type of message ( email, sms ) But if you try to use --type like this: process_message_queue.pl -v --type=sms" <instance> You get this error: Option type does not take an argument This is because the setup of the type argument is wrong. This: 't|type' => \$type, should be this: 't|type:s' => \$type,