Summary: | Add branch param to C4::SIP->checkout | ||
---|---|---|---|
Product: | Koha | Reporter: | Benjamin Rokseth <benjamin.rokseth> |
Component: | SIP2 | Assignee: | Benjamin Rokseth <benjamin.rokseth> |
Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | aleisha, black23, colin.campbell, josef.moravec, martin.renvoize |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 21326: C4::SIP::ILS add missing branch param
Bug 21326: C4::SIP::ILS add missing branch param |
Description
Benjamin Rokseth
2018-09-10 13:28:48 UTC
Created attachment 78541 [details] [review] Bug 21326: C4::SIP::ILS add missing branch param ILS::Transaction was missing branch param for unknown reason. Since every transactions needs a branch, it makes sense to include it in the object and allow as param. This patch only adds the param to the object and ILS->checkout so it can be used in submodules. Hi Benjamin, Can you please provide a test plan for this? Maybe ensuring it doesn't break anything? Thanks Aleisha Well there isn't much to test really, it's just an extra param that isnt used anywhere yet. Afraid I cannot help more, since we dont know if anyone else use it Hi Benjamin, please don't forget to assign the bug to yourself when providing a patch! Created attachment 84014 [details] [review] Bug 21326: C4::SIP::ILS add missing branch param ILS::Transaction was missing branch param for unknown reason. Since every transactions needs a branch, it makes sense to include it in the object and allow as param. This patch only adds the param to the object and ILS->checkout so it can be used in submodules. Signed-off-by: Ethan Amohia <ethan.amohia@gmail.com> I can't see that this achieves anything, but please correct me if I'm wrong. For checkouts we use the AddIssue function and that doesn't expect a branch to be passed (and nor are we passing one to any other routines called from within C4::SIP::ILS::Transaction::Checkout->checkout_ok) I can't see that this addition actually goes anywhere.. failing QA for now until I get some feedback/perspective. Please clarify 'used in submodules'.. that might be a use case I'm entirely overlooking/not understanding. |