Bug 21340

Summary: Add spans with classes around callnumbers in OPAC for additional styling
Product: Koha Reporter: Kyle M Hall <kyle>
Component: OPACAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: katrin.fischer, martin.renvoize, mtompset, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling
Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling
Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling
Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling
Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling
Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling
Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling
Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling
Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling

Description Kyle M Hall 2018-09-12 16:38:18 UTC
It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well.
Comment 1 Kyle M Hall 2018-09-12 16:41:24 UTC
Created attachment 78596 [details] [review]
Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling

It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well.
Comment 2 ByWater Sandboxes 2018-09-14 23:54:13 UTC
Created attachment 78850 [details] [review]
Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling

It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well.

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>
Comment 3 ByWater Sandboxes 2018-09-15 16:02:46 UTC
Created attachment 78852 [details] [review]
Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling

It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well.

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>
Comment 4 ByWater Sandboxes 2018-09-15 16:07:09 UTC
Created attachment 78853 [details] [review]
Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling

It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well.

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter vk <petter@libriotech.no>
Comment 5 ByWater Sandboxes 2018-09-15 16:40:29 UTC
Created attachment 78855 [details] [review]
Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling

It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well.

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter vk <petter@libriotech.no>

Signed-off-by: Petter vk <petter@libriotech.no>
Comment 6 ByWater Sandboxes 2018-09-15 16:46:46 UTC
Created attachment 78857 [details] [review]
Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling

It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well.

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter vk <petter@libriotech.no>

Signed-off-by: Petter vk <petter@libriotech.no>

Signed-off-by: Petter vk <petter@libriotech.no>
Comment 7 ByWater Sandboxes 2018-09-15 17:32:41 UTC
Created attachment 78866 [details] [review]
Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling

It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well.

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Petter vk <petter@libriotech.no>

Signed-off-by: Petter vk <petter@libriotech.no>

Signed-off-by: Petter vk <petter@libriotech.no>

Signed-off-by: Petter vk <petter@libriotech.no>
Comment 8 Mark Tompsett 2018-09-19 15:08:06 UTC
As you can see by the excessive signed-off-by's below, I'm pretty sure Petter is experiencing this ByWater Sandboxes not signing off problem.
Comment 9 Kyle M Hall 2018-09-20 13:54:40 UTC
Created attachment 79180 [details] [review]
Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling

It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well.

Signed-off-by: Petter <petter@libriotech.no>
Comment 10 Katrin Fischer 2018-09-25 05:40:46 UTC
Maybe a silly question, but how do you make the callnumber show up in the result list? I tried OPACItemsResultsDisplay, but that didn't work.
Comment 11 Katrin Fischer 2018-09-25 05:55:45 UTC
Turns out it helps when your items actually have callnumbers :)
Comment 12 Katrin Fischer 2018-09-25 05:58:10 UTC
Created attachment 79354 [details] [review]
Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling

It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well.

Signed-off-by: Petter <petter@libriotech.no>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 13 Nick Clemens (kidclamp) 2018-10-01 16:45:02 UTC
Awesome work all!

Pushed to master for 18.11
Comment 14 Martin Renvoize 2018-10-05 15:42:28 UTC
Enhancement will not be backported to 18.05.x series.