| Summary: | Automatic renewal cronjob doesn't send notices according to patron language preference | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Björn Nylén <bjorn.nylen> |
| Component: | Notices | Assignee: | Björn Nylén <bjorn.nylen> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 21343: Add language preference to automatic renewal notice
Bug 21343: Automatic renewal notice will now respect patron language preference. Bug 21343: Respect patron language preference in automtic renewals Bug 21343: Respect patron language preference in automtic renewals |
||
|
Description
Björn Nylén
2018-09-14 06:58:00 UTC
Created attachment 78630 [details] [review] Bug 21343: Add language preference to automatic renewal notice Bug 21343: Automatic renewal notice will now respect patron language preference. To test: 1) Set up different automatic renewal notices for Default and one other language 2) Make sure you have checkouts due for auto-renewal to patrons with non-Default language pref 3) Run automatic_renewals.pl . All patrons will get the default-language notice 4) Apply patch. 5) Repeat 2) 6) Run automatic_renewals.pl . Patrons will receive notices according to their language preference. Hi Björn, please don't forget to assign the bug to yourself when providing a patch! Created attachment 93504 [details] [review] Bug 21343: Automatic renewal notice will now respect patron language preference. To test: 1) Set up different automatic renewal notices for Default and one other language 2) Make sure you have checkouts due for auto-renewal to patrons with non-Default language pref 3) Run automatic_renewals.pl . All patrons will get the default-language notice 4) Apply patch. 5) Repeat 2) 6) Run automatic_renewals.pl . Patrons will receive notices according to their language preference. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 93505 [details] [review] Bug 21343: Respect patron language preference in automtic renewals To test: 1) Set up different automatic renewal notices for Default and one other language 2) Make sure you have checkouts due for auto-renewal to patrons with non-Default language pref 3) Run automatic_renewals.pl . All patrons will get the default-language notice 4) Apply patch. 5) Repeat 2) 6) Run automatic_renewals.pl . Patrons will receive notices according to their language preference. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> All works as expected, a great first patch Björn, Signing off. The bug states it's sponsored, could we get the sponsor name so we can add it to the patch for proper attribution? Created attachment 93566 [details] [review] Bug 21343: Respect patron language preference in automtic renewals To test: 1) Set up different automatic renewal notices for Default and one other language 2) Make sure you have checkouts due for auto-renewal to patrons with non-Default language pref 3) Run automatic_renewals.pl . All patrons will get the default-language notice 4) Apply patch. 5) Repeat 2) 6) Run automatic_renewals.pl . Patrons will receive notices according to their language preference. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Thankyou for your first submission Björn, welcome to Koha's development team :). I've added full attribution to your employer for the sponsorship notes whilst pushing the patch too: Sponsored-by: Lund University Library Nice work! Pushed to master for 19.11.00 |