Summary: | Merge patrons option only available with manage_patron_lists | ||
---|---|---|---|
Product: | Koha | Reporter: | Séverine Queune <severine.queune> |
Component: | Patrons | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, martin.renvoize, nick, sandboxes |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 21353: Display checkboxes to merge patron even if cannot manage lists
Bug 21353: (follow-up) same check for select/clear all links Bug 21353: Display checkboxes to merge patron even if cannot manage lists Bug 21353: (follow-up) same check for select/clear all links Bug 21353: Display checkboxes to merge patron even if cannot manage lists Bug 21353: (follow-up) same check for select/clear all links |
Description
Séverine Queune
2018-09-15 16:32:16 UTC
Created attachment 78872 [details] [review] Bug 21353: Display checkboxes to merge patron even if cannot manage lists When permission 'manage_patron_lists' is off, there is no checkbox on /cgi-bin/koha/members/member.pl to merge patrons. Test plan: Remove permission manage_patron_lists Add permission edit_borrowers Search for patrons => Without this patch you will not be able to select patrons to merge (checkboxes are not displayed) The "Select all // Clear all" options are only display with permission 'manage_patron_lists'. It think it's display should not dependant on any permission for it's useful for both actions (list + merge). Created attachment 78957 [details] [review] Bug 21353: (follow-up) same check for select/clear all links Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 78971 [details] [review] Bug 21353: Display checkboxes to merge patron even if cannot manage lists When permission 'manage_patron_lists' is off, there is no checkbox on /cgi-bin/koha/members/member.pl to merge patrons. Test plan: Remove permission manage_patron_lists Add permission edit_borrowers Search for patrons => Without this patch you will not be able to select patrons to merge (checkboxes are not displayed) Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 78972 [details] [review] Bug 21353: (follow-up) same check for select/clear all links Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 79335 [details] [review] Bug 21353: Display checkboxes to merge patron even if cannot manage lists When permission 'manage_patron_lists' is off, there is no checkbox on /cgi-bin/koha/members/member.pl to merge patrons. Test plan: Remove permission manage_patron_lists Add permission edit_borrowers Search for patrons => Without this patch you will not be able to select patrons to merge (checkboxes are not displayed) Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 79336 [details] [review] Bug 21353: (follow-up) same check for select/clear all links Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.05 Pushed to 17.11.x for 17.11.11 (In reply to Fridolin SOMERS from comment #11) > Pushed to 17.11.x for 17.11.11 Arf brakes template, I revert from 17.11.x |