Summary: | GetDailyQuotes.t is fragile | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 20144 | ||
Bug Blocks: | |||
Attachments: |
Bug 21355: Prevent GetDailyQuote.t to fail when run after 23:00
Bug 21355: Prevent GetDailyQuote.t to fail when run after 23:00 |
Description
Tomás Cohen Arazi (tcohen)
2018-09-15 18:26:06 UTC
Created attachment 78873 [details] [review] Bug 21355: Prevent GetDailyQuote.t to fail when run after 23:00 Tests will fail (Jenkins run #554) if run after 23:00 # Failed test 'Id is correct' # at t/db_dependent/Koha/GetDailyQuote.t line 72. # got: 6 # expected: 8 # Failed test 'Timestamp 2018-09-15 00:44:46 is correct' # at t/db_dependent/Koha/GetDailyQuote.t line 74. # got: '2018-09-14 23:44:46' # expected: '2018-09-15 00:44:46' # Looks like you failed 2 tests of 12. [23:44:46] t/db_dependent/Koha/GetDailyQuote.t Dubious, test returned 2 (wstat 512, 0x200) Adding only 1 second will hugely reduce the risk of failure here. It also updates a useless test (column 'quote' does not exist) Created attachment 78876 [details] [review] Bug 21355: Prevent GetDailyQuote.t to fail when run after 23:00 Tests will fail (Jenkins run #554) if run after 23:00 # Failed test 'Id is correct' # at t/db_dependent/Koha/GetDailyQuote.t line 72. # got: 6 # expected: 8 # Failed test 'Timestamp 2018-09-15 00:44:46 is correct' # at t/db_dependent/Koha/GetDailyQuote.t line 74. # got: '2018-09-14 23:44:46' # expected: '2018-09-15 00:44:46' # Looks like you failed 2 tests of 12. [23:44:46] t/db_dependent/Koha/GetDailyQuote.t Dubious, test returned 2 (wstat 512, 0x200) Adding only 1 second will hugely reduce the risk of failure here. It also updates a useless test (column 'quote' does not exist) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Tested: - Run: $ sudo date -s 2018-09-15T23:10:00 $ kshell k$ prove t/db_dependent/Koha/GetDailyQuote.t => FAIL: Tests fail as patch author mentions - Apply the patch k$ prove t/db_dependent/Koha/GetDailyQuote.t => SUCCESS: Tests pass! :_D Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.04 |