Summary: | IssueSlip.t is failing if run at 23:59 | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 15029 | ||
Bug Blocks: | |||
Attachments: | Bug 21360: Prevent IssueSlip.t to fail when run at 23:59 |
Description
Jonathan Druart
2018-09-16 16:49:22 UTC
Created attachment 78937 [details] [review] Bug 21360: Prevent IssueSlip.t to fail when run at 23:59 Not sure what happened on bug 15029 (Make the IssueSlip tests pass even if launched after 23:00) but we should have tested with 23:59, not 23:50... koha_1 | # Looks like you planned 3 tests but ran 2. koha_1 | koha_1 | # Failed test 'Issue slip' koha_1 | # at t/db_dependent/Members/IssueSlip.t line 294. koha_1 | Label not found for "last SKIP" at /usr/share/perl5/Test/More.pm line 1370. koha_1 | # Looks like your test exited with 255 just after 1. koha_1 | [23:59:10] t/db_dependent/Members/IssueSlip.t koha_1 | Dubious, test returned 255 (wstat 65280, 0xff00) koha_1 | Failed 3/3 subtests Test plan: 0/ Don't apply this patch 1/ sudo date -s "2018-09-15 23:59:00";prove t/db_dependent/Members/IssueSlip.t => You should get the error 2/ Apply this patch and repeat 1. => Tests should pass now! Tested, works as expected, minor patch, skipping QA Thanks Jonathan Pushed to master for 18.11 Pushed to 18.05.x for 18.05.04. Pushed to 17.11.x for 17.11.10 |