Description
Martin Renvoize (ashimema)
2018-09-20 13:31:41 UTC
Created attachment 79235 [details] [review] Bug 21385: Correctly count all items in basket for booksellers list Created attachment 79280 [details] [review] Bug 21385: Correctly count all items in basket for booksellers list Test additions to follow. Created attachment 79301 [details] [review] Bug 21385: Add Unit Tests Created attachment 79303 [details] [review] Bug 21385: Correctly count all items in basket for booksellers list Created attachment 79304 [details] [review] Bug 21385: Add Unit Tests Created attachment 79305 [details] [review] Bug 21385: (followup) - make query consistent The expected items query wasn't consistent with other queries in this module with regards to identifying cancelled orders I'm struggling on the test.. I'm sure it's testing correctly, but it would appear the expected items is coming out wrong.. any pointers welcome. Created attachment 79362 [details] [review] Bug 21385: Correctly count all items in basket for booksellers list Created attachment 79363 [details] [review] Bug 21385: Add Unit Tests Created attachment 79364 [details] [review] Bug 21385: (followup) - make query consistent The expected items query wasn't consistent with other queries in this module with regards to identifying cancelled orders Created attachment 79365 [details] [review] Bug 21385: (followup) Workaround for bug in get_from_storage method Test fixed. Item count stays the same. (In reply to Caroline Cyr La Rose from comment #14) > Item count stays the same. You changed the status to "Signed Off", I guess it was not expected :) The signoff was good. It worked as expected. The patch was meant to make sure the item count in a basket stayed the same even when the order was partially received. Created attachment 79721 [details] [review] Bug 21385: Define the Koha object class for orders It fixes the following issue: t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t .. 1/40 Can't locate object method "_new_from_dbic" via package "Koha::Aqorder" (perhaps you forgot to load "Koha::Aqorder"?) at /home/vagrant/kohaclone/Koha/Object.pm line 230. Created attachment 79727 [details] [review] Bug 21385: Correctly count all items in basket for booksellers list To reproduce: 1) Create a basket with 2 biblios, one with 2 items and one with 1 item 2) Search for vendors and note the basket above should contain 'Item count 3', 'Biblio count 2', 'Items expected 3' 3) Receive shipment, and only receive 1 of the items on the biblio with 2 items above. 4) Search for vendors and note that the 'Item count' for the basket above is now '2'. The item count for a closed basket should remain the same and should differ from the 'items expected' count some items have been recieved. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: FAIL C4/Acquisition.pm FAIL spelling RECIEVED ==> RECEIVED Created attachment 79728 [details] [review] Bug 21385: Add Unit Tests Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 79729 [details] [review] Bug 21385: (follow-up) make query consistent The expected items query wasn't consistent with other queries in this module with regards to identifying cancelled orders Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 79730 [details] [review] Bug 21385: Define the Koha object class for orders It fixes the following issue: t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t .. 1/40 Can't locate object method "_new_from_dbic" via package "Koha::Aqorder" (perhaps you forgot to load "Koha::Aqorder"?) at /home/vagrant/kohaclone/Koha/Object.pm line 230. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Thanks for adding the followup Jonathan, my brain was struggling to work that one out (even after asking Kyle for assistance).. Now I know what to look if I come across a similar issue. Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.05 I try to apply to 17.11 but UT does not pass, I've asked for help. |