Description
Josef Moravec
2018-09-25 05:59:44 UTC
Created attachment 79357 [details] [review] Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query Created attachment 79358 [details] [review] Bug 21404: Update test Created attachment 79359 [details] [review] Bug 21404: Refactor _build_query subroutines Test plan: 1) Apply the patch 2) prove t/db_dependent/Breeding.t 3) Try to search using Z39.50, both, authority and biblio should still work Created attachment 79443 [details] [review] Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 79444 [details] [review] Bug 21404: Update test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 79445 [details] [review] Bug 21404: Refactor _build_query subroutines Test plan: 1) Apply the patch 2) prove t/db_dependent/Breeding.t 3) Try to search using Z39.50, both, authority and biblio should still work Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 79492 [details] [review] Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 79493 [details] [review] Bug 21404: Update test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 79494 [details] [review] Bug 21404: Refactor _build_query subroutines Test plan: 1) Apply the patch 2) prove t/db_dependent/Breeding.t 3) Try to search using Z39.50, both, authority and biblio should still work Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 |