Bug 21404

Summary: Remove unused variables in C4::Breeding->_auth_build_query
Product: Koha Reporter: Josef Moravec <josef.moravec>
Component: Architecture, internals, and plumbingAssignee: Josef Moravec <josef.moravec>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: martin.renvoize, nick
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436
Change sponsored?: --- Patch complexity: Medium patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 21318    
Bug Blocks:    
Attachments: Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query
Bug 21404: Update test
Bug 21404: Refactor _build_query subroutines
Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query
Bug 21404: Update test
Bug 21404: Refactor _build_query subroutines
Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query
Bug 21404: Update test
Bug 21404: Refactor _build_query subroutines

Description Josef Moravec 2018-09-25 05:59:44 UTC

    
Comment 1 Josef Moravec 2018-09-25 07:07:12 UTC
Created attachment 79357 [details] [review]
Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query
Comment 2 Josef Moravec 2018-09-25 07:07:15 UTC
Created attachment 79358 [details] [review]
Bug 21404: Update test
Comment 3 Josef Moravec 2018-09-25 07:07:19 UTC
Created attachment 79359 [details] [review]
Bug 21404: Refactor _build_query subroutines

Test plan:
1) Apply the patch
2) prove t/db_dependent/Breeding.t
3) Try to search using Z39.50, both, authority and biblio should still
work
Comment 4 Owen Leonard 2018-09-26 18:46:50 UTC
Created attachment 79443 [details] [review]
Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Owen Leonard 2018-09-26 18:46:54 UTC
Created attachment 79444 [details] [review]
Bug 21404: Update test

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 6 Owen Leonard 2018-09-26 18:46:57 UTC
Created attachment 79445 [details] [review]
Bug 21404: Refactor _build_query subroutines

Test plan:
1) Apply the patch
2) prove t/db_dependent/Breeding.t
3) Try to search using Z39.50, both, authority and biblio should still
work

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Katrin Fischer 2018-09-27 12:39:35 UTC
Created attachment 79492 [details] [review]
Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Katrin Fischer 2018-09-27 12:39:39 UTC
Created attachment 79493 [details] [review]
Bug 21404: Update test

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Katrin Fischer 2018-09-27 12:39:44 UTC
Created attachment 79494 [details] [review]
Bug 21404: Refactor _build_query subroutines

Test plan:
1) Apply the patch
2) prove t/db_dependent/Breeding.t
3) Try to search using Z39.50, both, authority and biblio should still
work

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Nick Clemens (kidclamp) 2018-10-01 16:45:44 UTC
Awesome work all!

Pushed to master for 18.11
Comment 11 Martin Renvoize 2018-10-05 12:17:30 UTC
Depends on bug 21318 not in 18.05.x, caused by bug 19436 not in 18.05.x.  Marking as RESOLVED FIXED