Summary: | Can't enter new macros in the advanced cataloging editor (rancor) | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Cataloging | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aspencatteam, fridolin.somers, m.de.rooy, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 21407: Can't enter new macros in the advanced cataloging editor (rancor)
Bug 21407: Can't enter new macros in the advanced cataloging editor (rancor) Bug 21407: Can't enter new macros in the advanced cataloging editor (rancor) |
Description
Nick Clemens (kidclamp)
2018-09-25 10:33:17 UTC
It appears that a Codemirror upgrade fixes this. Created attachment 79382 [details] [review] Bug 21407: Can't enter new macros in the advanced cataloging editor (rancor) This patch upgrades Codemirror to the latest version (5.40.2). Doing so fixes a problem with the advanced cataloging editor's macro editor which appears in the latest version of Firefox (62): The first line of the macro editor is not visible. To test, apply the patch and clear your browser cache if necessary. EnableAdvancedCatalogingEditor must be set to "Enable." - Go to Cataloging -> Advanced editor. - Click the "Macros" toolbar button. - In the main part of this modal window you should see a blank line marked "1." - Click "New macro..." - The editor's line 1 should now be editable. Enter text to confirm that it works correctly. Created attachment 79463 [details] [review] Bug 21407: Can't enter new macros in the advanced cataloging editor (rancor) This patch upgrades Codemirror to the latest version (5.40.2). Doing so fixes a problem with the advanced cataloging editor's macro editor which appears in the latest version of Firefox (62): The first line of the macro editor is not visible. To test, apply the patch and clear your browser cache if necessary. EnableAdvancedCatalogingEditor must be set to "Enable." - Go to Cataloging -> Advanced editor. - Click the "Macros" toolbar button. - In the main part of this modal window you should see a blank line marked "1." - Click "New macro..." - The editor's line 1 should now be editable. Enter text to confirm that it works correctly. Signed-off-by: Michal Denar <black23@gmail.com> Created attachment 79472 [details] [review] Bug 21407: Can't enter new macros in the advanced cataloging editor (rancor) This patch upgrades Codemirror to the latest version (5.40.2). Doing so fixes a problem with the advanced cataloging editor's macro editor which appears in the latest version of Firefox (62): The first line of the macro editor is not visible. To test, apply the patch and clear your browser cache if necessary. EnableAdvancedCatalogingEditor must be set to "Enable." - Go to Cataloging -> Advanced editor. - Click the "Macros" toolbar button. - In the main part of this modal window you should see a blank line marked "1." - Click "New macro..." - The editor's line 1 should now be editable. Enter text to confirm that it works correctly. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.05 Pushed to 17.11.x for 17.11.11 This is quite frustrating as it seems browser dependent. Are you suggesting there's still a problem here? If that's the case can you open a new bug and describe how to replicate it including which browser it is presenting in. (In reply to Martin Renvoize from comment #9) > Are you suggesting there's still a problem here? If that's the case can you > open a new bug and describe how to replicate it including which browser it > is presenting in. Sorry - The patch which fixed this is loaded to our test site, so all is good. New to the system. |