Summary: | basketno not being interpolated into error message | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | Acquisitions | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Patch to correctly display basketno
Bug 21425 Display basketno correctly in Order error msg Bug 21425 Display basketno correctly in Order error msg |
Description
Colin Campbell
2018-09-27 11:23:26 UTC
Created attachment 79480 [details] [review] Patch to correctly display basketno Created attachment 79487 [details] [review] Bug 21425 Display basketno correctly in Order error msg carp will display the hash value instead of the desired basketno in the error message unless we change its behaviour Use the simpler but effective option of concatenating the errormessage with the basketno. Error is shown if no sender or receipient ean is passed in instantiating an Koha::Edifact::Order object Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Still no test for this module? Created attachment 79667 [details] [review] Bug 21425 Display basketno correctly in Order error msg carp will display the hash value instead of the desired basketno in the error message unless we change its behaviour Use the simpler but effective option of concatenating the errormessage with the basketno. Error is shown if no sender or receipient ean is passed in instantiating an Koha::Edifact::Order object Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.05 Pushed to 17.11.x for 17.11.11 |