|
Description
Andreas Roussos
2018-09-27 11:29:54 UTC
Created attachment 79481 [details] [review] Bug 21426: setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect Setting USE_MEMCACHED to "no" in /etc/koha/koha-sites.conf does not have any effect, because as of Bug 18342 memcached is enabled by default for new installations. With the proposed patch this potential source of confusion is removed from the configuration file. Test plan: 1) view koha-sites.conf and notice that you are given the option to set USE_MEMCACHED to either "yes" or "no" (the default being "yes") 2) apply the patch 3) this time the "Memcached global configuration variables" section should point out that new instances will use memcached by default Created attachment 79603 [details] [review] Bug 21426: setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect Setting USE_MEMCACHED to "no" in /etc/koha/koha-sites.conf does not have any effect, because as of Bug 18342 memcached is enabled by default for new installations. With the proposed patch this potential source of confusion is removed from the configuration file. Test plan: 1) view koha-sites.conf and notice that you are given the option to set USE_MEMCACHED to either "yes" or "no" (the default being "yes") 2) apply the patch 3) this time the "Memcached global configuration variables" section should point out that new instances will use memcached by default Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> I am wondering if this is the right fix, I guess we should handle the "no" value instead. Created attachment 79617 [details] [review] [ALTERNATIVE-PATCH] Bug 21426: Handle USE_MEMCACHED=no in koha-create What about this alternative patch? (In reply to Jonathan Druart from comment #3) > I am wondering if this is the right fix, I guess we should handle the "no" > value instead. Fine with me :-) FWIW my interpretation of the changes and comments in Bug 18342 was that it would no longer be possible to create an install without memcached, and I based my patch on that. I'll obsolete it now. (In reply to Jonathan Druart from comment #5) > What about this alternative patch? Looks OK overall; is the echo bit above the if statement intentional? Created attachment 79660 [details] [review] Bug 21426: Handle USE_MEMCACHED=no in koha-create (In reply to Andreas Roussos from comment #6) > (In reply to Jonathan Druart from comment #5) > > What about this alternative patch? > Looks OK overall; is the echo bit above the if statement intentional? Of course no, I amended the patch. (In reply to Andreas Roussos from comment #0) > Oddly enough, once my instance was up and running I noticed that a > memcached process had been started (Home > About Koha in the Staff > interface also reported memcached as running). Actually, the memcached process had been there all along. The daemon is set to start automatically for runlevel 3 ('multi-user.target' in systemd-speak). Created attachment 79718 [details] [review] Bug 21426: Handle USE_MEMCACHED=no in koha-create Signed-off-by: Andreas Roussos <arouss1980@gmail.com> Works as intended. I've set USE_MEMCACHED to "no" and created a new Koha instance. Home > About now reports this information: Memcached: Servers: undefined | Namespace: undefined | Status: unknown | Config read from: Nowhere [...] | Effective caching method: Cache::Memory Created attachment 80238 [details] [review] Bug 21426: Handle USE_MEMCACHED=no in koha-create Signed-off-by: Andreas Roussos <arouss1980@gmail.com> Works as intended. I've set USE_MEMCACHED to "no" and created a new Koha instance. Home > About now reports this information: Memcached: Servers: undefined | Namespace: undefined | Status: unknown | Config read from: Nowhere [...] | Effective caching method: Cache::Memory Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.05 Depends on Bug 18342 not in 17.11.x |