Bug 21429

Summary: Switch two-column templates to Bootstrap grid: Reports part 2
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: martin.renvoize, nick, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 20654    
Attachments: Bug 21429: Update two-column templates with Bootstrap grid: Reports part 2
Bug 21429: Update two-column templates with Bootstrap grid: Reports part 2
Bug 21429: Update two-column templates with Bootstrap grid: Reports part 2

Description Owen Leonard 2018-09-27 12:12:08 UTC
These two-column reports templates can be updated to use the Bootstrap grid.

 - reports/itemslost.tt
 - reports/itemtypes.tt
 - reports/orders_by_budget.tt
 - reports/reserves_stats.tt
 - reports/serials_stats.tt
Comment 1 Owen Leonard 2018-09-27 12:18:10 UTC
Created attachment 79489 [details] [review]
Bug 21429: Update two-column templates with Bootstrap grid: Reports part 2

This patch modifies several reports templates to use the
Bootstrap grid instead of YUI.

A couple of markup errors have been fixed in reports/itemslost.tt.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Reports -> Lost items
 - Reports -> Catalog by item type
 - Reports -> Orders by fund
 - Reports -> Holds statistics wizard
 - Reports -> Serials statistics wizard
Comment 2 Claire Gravely 2018-10-01 08:54:24 UTC
Created attachment 79694 [details] [review]
Bug 21429: Update two-column templates with Bootstrap grid: Reports part 2

This patch modifies several reports templates to use the
Bootstrap grid instead of YUI.

A couple of markup errors have been fixed in reports/itemslost.tt.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Reports -> Lost items
 - Reports -> Catalog by item type
 - Reports -> Orders by fund
 - Reports -> Holds statistics wizard
 - Reports -> Serials statistics wizard

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 3 Jonathan Druart 2018-10-01 15:05:43 UTC
Created attachment 79732 [details] [review]
Bug 21429: Update two-column templates with Bootstrap grid: Reports part 2

This patch modifies several reports templates to use the
Bootstrap grid instead of YUI.

A couple of markup errors have been fixed in reports/itemslost.tt.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Reports -> Lost items
 - Reports -> Catalog by item type
 - Reports -> Orders by fund
 - Reports -> Holds statistics wizard
 - Reports -> Serials statistics wizard

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Nick Clemens 2018-10-02 00:14:30 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-10-08 08:29:45 UTC
Enhancement, will not be backported to 18.05.x series.