Summary: | Differentiate password change and password reset in action logs | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Patrons | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | Needs documenting --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kebliss, kyle.m.hall, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
Circulation function: | |||
Bug Depends on: | 21178 | ||
Bug Blocks: | |||
Attachments: |
Bug 21431: Add action parameter to set_password
Bug 21431: Add unit test Bug 21431: Adjust template for logviewer Bug 21431: Add action parameter to set_password Bug 21431: Add unit test Bug 21431: Adjust template for logviewer Bug 21431: Add action parameter to set_password Bug 21431: Add unit test Bug 21431: Adjust template for logviewer |
Description
Marcel de Rooy
2018-09-27 13:34:04 UTC
Dep 21178 for update_password vs set_password Hi Marcel, I don't fully understand the problem you describe. Is this still valid? (In reply to Katrin Fischer from comment #2) > Hi Marcel, I don't fully understand the problem you describe. Is this still > valid? Yes it is. Will send a patch. Created attachment 158256 [details] [review] Bug 21431: Add action parameter to set_password Added to the call in opac-password-recovery.pl. This allows differentiating between password change and password reset when viewing the logs. Test plan: Enable BorrowersLog. Do a password recovery on OPAC. Check with log viewer for 'RESET PASS' action. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 158257 [details] [review] Bug 21431: Add unit test Test plan: Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 158258 [details] [review] Bug 21431: Adjust template for logviewer Test plan: Verify that you can filter by reset password. And that the uppercase code is replaced by a description. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 158268 [details] [review] Bug 21431: Add action parameter to set_password Added to the call in opac-password-recovery.pl. This allows differentiating between password change and password reset when viewing the logs. Test plan: Enable BorrowersLog. Do a password recovery on OPAC. Check with log viewer for 'RESET PASS' action. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 158269 [details] [review] Bug 21431: Add unit test Test plan: Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 158270 [details] [review] Bug 21431: Adjust template for logviewer Test plan: Verify that you can filter by reset password. And that the uppercase code is replaced by a description. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> (In reply to Matt Blenkinsop from comment #9) > Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Thx Matt ! Created attachment 158660 [details] [review] Bug 21431: Add action parameter to set_password Added to the call in opac-password-recovery.pl. This allows differentiating between password change and password reset when viewing the logs. Test plan: Enable BorrowersLog. Do a password recovery on OPAC. Check with log viewer for 'RESET PASS' action. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 158661 [details] [review] Bug 21431: Add unit test Test plan: Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 158662 [details] [review] Bug 21431: Adjust template for logviewer Test plan: Verify that you can filter by reset password. And that the uppercase code is replaced by a description. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> All working as described.. QA scripts happy and tests passing. Passing QA Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x I believe we have a list of these in the manual (I see to remember translating these) |