Bug 21433

Summary: Switch two-column templates to Bootstrap grid: Tools part 1
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: enhancement    
Priority: P5 - low CC: josef.moravec, lucas, martin.renvoize, nick, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 20654    
Attachments: Bug 21433: Update two-column templates with Bootstrap grid: Tools part 1
Bug 21433: Update two-column templates with Bootstrap grid: Tools part 1
Bug 21433: Update two-column templates with Bootstrap grid: Tools part 1

Description Owen Leonard 2018-09-27 14:26:16 UTC
These two-column tools templates can be updated to use the Bootstrap grid.

 - tools/automatic_item_modification_by_age.tt
 - tools/batchMod.tt
 - tools/batch_delete_records.tt
 - tools/batch_record_modification.tt
 - tools/cleanborrowers.tt
 - tools/csv-profiles.tt
Comment 1 Owen Leonard 2018-09-27 14:40:05 UTC Comment hidden (obsolete)
Comment 2 Lucas Gass (lukeg) 2018-10-08 21:19:45 UTC
Created attachment 80239 [details] [review]
Bug 21433: Update two-column templates with Bootstrap grid: Tools part 1

This patch modifies several tools templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Automatic item modifications by age
   - View and edit rules
 - Tools -> Batch item modification start page
 - Tools -> Batch delete records
   - Starting page
   - Confirmation page
   - Completion page
 - Tools -> Batch record modification
   - Starting page
   - Confirmation page
   - Completion page
 - Tools -> Batch patron deletion/anonymization
   - Starting page
   - Confirmation page
   - Completion page
 - Tools -> CSV profiles
   - View and edit CSV profiles

Signed-off-by: “Lucas Gass” <lucas@bywatersolutions.com>
Comment 3 Josef Moravec 2018-10-29 21:49:00 UTC
Created attachment 81592 [details] [review]
Bug 21433: Update two-column templates with Bootstrap grid: Tools part 1

This patch modifies several tools templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Automatic item modifications by age
   - View and edit rules
 - Tools -> Batch item modification start page
 - Tools -> Batch delete records
   - Starting page
   - Confirmation page
   - Completion page
 - Tools -> Batch record modification
   - Starting page
   - Confirmation page
   - Completion page
 - Tools -> Batch patron deletion/anonymization
   - Starting page
   - Confirmation page
   - Completion page
 - Tools -> CSV profiles
   - View and edit CSV profiles

Signed-off-by: “Lucas Gass” <lucas@bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 4 Nick Clemens (kidclamp) 2018-11-08 02:27:18 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize (ashimema) 2018-11-16 12:55:05 UTC
Enhancement, will not be backported to 18.05.x series.