| Summary: | Field 606 doesn't add multiple x subfields | ||
|---|---|---|---|
| Product: | Koha | Reporter: | José Anjos <joseanjos> | 
| Component: | Cataloging | Assignee: | Jonathan Druart <jonathan.druart> | 
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> | 
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, m.de.rooy, martin.renvoize, nick | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Bug Depends on: | 18904 | ||
| Bug Blocks: | |||
| Attachments: | Bug 21448: Fix copy repeated subfields when linking an authority with 6xx Bug 21448: Fix copy repeated subfields when linking an authority with 6xx Bug 21448: Fix copy repeated subfields when linking an authority with 6xx | ||
| 
        
          Description
        
        
          José Anjos
        
        
        
        
          2018-09-28 13:35:31 UTC
        
       Caused by commit a7df1f9f8eb9ed16246964d94dd8a69b756b6551 Bug 18904: (follow-up) Retrieve subfield in the order they are stored Created attachment 79620 [details] [review] Bug 21448: Fix copy repeated subfields when linking an authority with 6xx The reported issue was: On field 606, if I use an Authority with multiple "x" subfields, it will add just the first "x" Error in the logs: Odd number of elements in anonymous hash at /home/vagrant/kohaclone/authorities/blinddetail-biblio-search.pl line 97. We should pass a ref (!), caused by commit a7df1f9f8eb9ed16246964d94dd8a69b756b6551 Bug 18904: (follow-up) Retrieve subfield in the order they are stored Test plan: Edit an authority and add several $x to 600 Link this authority to a bibliographic record => Without this patch only the first subfield is copied => With this patch applied they are all copied (In reply to Jonathan Druart from comment #2) > Created attachment 79620 [details] [review] [review] > Bug 21448: Fix copy repeated subfields when linking an authority with 6xx > > The reported issue was: > On field 606, if I use an Authority with multiple "x" subfields, it will > add just the first "x" > > Error in the logs: > Odd number of elements in anonymous hash at > /home/vagrant/kohaclone/authorities/blinddetail-biblio-search.pl line 97. > > We should pass a ref (!), caused by > commit a7df1f9f8eb9ed16246964d94dd8a69b756b6551 > Bug 18904: (follow-up) Retrieve subfield in the order they are stored > > Test plan: > Edit an authority and add several $x to 600 > Link this authority to a bibliographic record > => Without this patch only the first subfield is copied > => With this patch applied they are all copied Tested. It works fine :) Thank you very much Created attachment 79710 [details] [review] Bug 21448: Fix copy repeated subfields when linking an authority with 6xx The reported issue was: On field 606, if I use an Authority with multiple "x" subfields, it will add just the first "x" Error in the logs: Odd number of elements in anonymous hash at /home/vagrant/kohaclone/authorities/blinddetail-biblio-search.pl line 97. We should pass a ref (!), caused by commit a7df1f9f8eb9ed16246964d94dd8a69b756b6551 Bug 18904: (follow-up) Retrieve subfield in the order they are stored Test plan: Edit an authority and add several $x to 600 Link this authority to a bibliographic record => Without this patch only the first subfield is copied => With this patch applied they are all copied Signed-off-by: José Anjos <joseanjos@gmail.com> Hi José, thanks for testing. Do not forget to adjust the status, see also https://wiki.koha-community.org/wiki/Sign_off_on_patches Created attachment 79787 [details] [review] Bug 21448: Fix copy repeated subfields when linking an authority with 6xx The reported issue was: On field 606, if I use an Authority with multiple "x" subfields, it will add just the first "x" Error in the logs: Odd number of elements in anonymous hash at /home/vagrant/kohaclone/authorities/blinddetail-biblio-search.pl line 97. We should pass a ref (!), caused by commit a7df1f9f8eb9ed16246964d94dd8a69b756b6551 Bug 18904: (follow-up) Retrieve subfield in the order they are stored Test plan: Edit an authority and add several $x to 600 Link this authority to a bibliographic record => Without this patch only the first subfield is copied => With this patch applied they are all copied Signed-off-by: José Anjos <joseanjos@gmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.05 |