Bug 21462

Summary: "Filter paid transactions" stopped working after html-table was changed
Product: Koha Reporter: Johan Larsson <johan.larsson>
Component: Fines and feesAssignee: Johan Larsson <johan.larsson>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: jonathan.druart, martin.renvoize, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 15136    
Bug Blocks:    
Attachments: wrong column was selected for filtering the table. This was caused by changing the hmtl-structure of the table
Bug 21462: (bug 15136 follow-up) Shift column numbering

Description Johan Larsson 2018-10-01 12:49:22 UTC
Related to 15136
Comment 1 Johan Larsson 2018-10-01 13:01:40 UTC
Created attachment 79713 [details] [review]
wrong column was selected for filtering the table. This was caused by changing the hmtl-structure of the table
Comment 2 Jonathan Druart 2018-10-01 16:24:12 UTC
Hi Johan, thanks for your patch.
Do not forget to switch the bug report's status to Needs Signoff to tell the community the patch is ready for testing.
You should also read this wiki page to format the commit message following our guide lines: https://wiki.koha-community.org/wiki/Commit_messages
Comment 3 Jonathan Druart 2018-10-01 16:24:35 UTC
Created attachment 79744 [details] [review]
Bug 21462: (bug 15136 follow-up) Shift column numbering

Wrong column was selected for filtering the table.
This was caused by changing the hmtl-structure of the table

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2018-10-01 16:24:55 UTC
Trivial patch, skipping QA.
Comment 5 Nick Clemens (kidclamp) 2018-10-02 00:15:15 UTC
Awesome work all!

Pushed to master for 18.11
Comment 6 Martin Renvoize (ashimema) 2018-10-08 08:06:48 UTC
Caused by enhancement not in 18.05.x series.