Bug 21491

Summary: When 'Default lost item fee refund on return policy' is unset it says no but acts as if 'yes'
Product: Koha Reporter: Nick Clemens <nick>
Component: CirculationAssignee: Nick Clemens <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: fridolin.somers, gmcharlt, jesse, kyle.m.hall, lisettepalouse+koha, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set
Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set
Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set
Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set

Description Nick Clemens 2018-10-04 16:50:15 UTC
To recreate:
1 - delete from refund_lost_item_fee_rules;
2 - View the Standard circ rules - Default lost item fee refund shows as 'No'
3 - View circ rules for a single library, shows as 'Default (Yes)'
4 - Return a lost item, it actually does refund
Comment 1 Nick Clemens 2018-11-21 13:46:33 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens 2018-11-26 13:02:13 UTC
Created attachment 82639 [details] [review]
Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set

To test:
1 - Delete all refund_lost_item_fee_rules form the db
    delete from refund_lost_item_fee_rules;
2 - View the Standard circ rules - Default lost item fee refund shows as
'No'
3 - View circ rules for a single library, shows as 'Default (Yes)'
4 - Return a lost item, it actually does refund (this is in the
        LostItemFeeRules code, default 1 if not set)
5 - Apply patch
6 - Rule shows as 'Yes'
7 - View a specifc rule, still says Default (Yes)
Comment 3 Martin Renvoize 2018-12-21 11:17:00 UTC
Created attachment 83443 [details] [review]
Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set

To test:
1 - Delete all refund_lost_item_fee_rules form the db
    delete from refund_lost_item_fee_rules;
2 - View the Standard circ rules - Default lost item fee refund shows as
'No'
3 - View circ rules for a single library, shows as 'Default (Yes)'
4 - Return a lost item, it actually does refund (this is in the
        LostItemFeeRules code, default 1 if not set)
5 - Apply patch
6 - Rule shows as 'Yes'
7 - View a specifc rule, still says Default (Yes)

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2018-12-21 11:17:47 UTC
SO hat on, works fine signing off..

QA hat on.. could we perhaps have a regression test for this?
Comment 5 Katrin Fischer 2019-01-13 22:32:32 UTC
Created attachment 83860 [details] [review]
Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set

To test:
1 - Delete all refund_lost_item_fee_rules form the db
    delete from refund_lost_item_fee_rules;
2 - View the Standard circ rules - Default lost item fee refund shows as
'No'
3 - View circ rules for a single library, shows as 'Default (Yes)'
4 - Return a lost item, it actually does refund (this is in the
        LostItemFeeRules code, default 1 if not set)
5 - Apply patch
6 - Rule shows as 'Yes'
7 - View a specifc rule, still says Default (Yes)

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Nick Clemens 2019-01-18 20:58:06 UTC
Awesome work all!

Pushed to master for 19.05
Comment 7 Martin Renvoize 2019-01-23 12:42:23 UTC
Pushed to 18.11.x for 18.11.03
Comment 8 Jesse Maseto 2019-01-23 19:27:16 UTC
Pushed to 18.05.x for 18.05.09
Comment 9 Fridolin Somers 2019-01-30 08:43:24 UTC
Pushed to 17.11.x for 17.11.15