Summary: | When 'Default lost item fee refund on return policy' is unset it says no but acts as if 'yes' | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Circulation | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jesse, kyle.m.hall, lisettepalouse+koha, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set
Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set |
Description
Nick Clemens (kidclamp)
2018-10-04 16:50:15 UTC
Created attachment 82561 [details] [review] Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set To test: 1 - Delete all refund_lost_item_fee_rules form the db delete from refund_lost_item_fee_rules; 2 - View the Standard circ rules - Default lost item fee refund shows as 'No' 3 - View circ rules for a single library, shows as 'Default (Yes)' 4 - Return a lost item, it actually does refund (this is in the LostItemFeeRules code, default 1 if not set) 5 - Apply patch 6 - Rule shows as 'Yes' 7 - View a specifc rule, still says Default (Yes) Created attachment 82639 [details] [review] Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set To test: 1 - Delete all refund_lost_item_fee_rules form the db delete from refund_lost_item_fee_rules; 2 - View the Standard circ rules - Default lost item fee refund shows as 'No' 3 - View circ rules for a single library, shows as 'Default (Yes)' 4 - Return a lost item, it actually does refund (this is in the LostItemFeeRules code, default 1 if not set) 5 - Apply patch 6 - Rule shows as 'Yes' 7 - View a specifc rule, still says Default (Yes) Created attachment 83443 [details] [review] Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set To test: 1 - Delete all refund_lost_item_fee_rules form the db delete from refund_lost_item_fee_rules; 2 - View the Standard circ rules - Default lost item fee refund shows as 'No' 3 - View circ rules for a single library, shows as 'Default (Yes)' 4 - Return a lost item, it actually does refund (this is in the LostItemFeeRules code, default 1 if not set) 5 - Apply patch 6 - Rule shows as 'Yes' 7 - View a specifc rule, still says Default (Yes) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> SO hat on, works fine signing off.. QA hat on.. could we perhaps have a regression test for this? Created attachment 83860 [details] [review] Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set To test: 1 - Delete all refund_lost_item_fee_rules form the db delete from refund_lost_item_fee_rules; 2 - View the Standard circ rules - Default lost item fee refund shows as 'No' 3 - View circ rules for a single library, shows as 'Default (Yes)' 4 - Return a lost item, it actually does refund (this is in the LostItemFeeRules code, default 1 if not set) 5 - Apply patch 6 - Rule shows as 'Yes' 7 - View a specifc rule, still says Default (Yes) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.03 Pushed to 18.05.x for 18.05.09 Pushed to 17.11.x for 17.11.15 |