Bug 21494

Summary: No checkin notice created for offline circulation checkins
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: gmcharlt, jonathan.druart, kyle.m.hall, rcoert, tgoatley
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25977
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Katrin Fischer 2018-10-05 07:55:34 UTC
When using the KOCT plugin for offline circulation, checkout notices are created correctly, but checkin notices are no longer created. 

To test:
- Check out an item via KOCT
- Send to Koha and process it there
- Verify that the checkout is on the account and a checkout notice has been generated
- Check in the item via KOCT
- Send to Koha and process it there
- Verify that the item is no longer on the account but NO checkin notice has been generated

This is quite a problem for libraries using the offline circulation plugin as they rely on the emails to inform the patrons.
Comment 1 Jonathan Druart 2018-12-07 14:01:54 UTC
Are you sure it is a regression?

CHECKIN notices are not generated because ProcessOfflineReturn does not call AddReturn but MarkIssueReturned instead (why??)
Comment 2 Katrin Fischer 2018-12-07 14:06:54 UTC
We got this report from libraries updated from 16.11 to 17.11 - I think it might just have been broken for too long already.
Comment 3 Katrin Fischer 2019-05-28 14:54:26 UTC
Jonathan, do you think the fix would be to use AddReturn? 

I haven't checked yet, but I think the only issue I could imagine is that you need to manipulate the time of return. But we can do that in the GUI, so I assume it should be possible.
Comment 4 Jonathan Druart 2019-05-28 23:55:01 UTC
(In reply to Katrin Fischer from comment #3)
> Jonathan, do you think the fix would be to use AddReturn? 
> 
> I haven't checked yet, but I think the only issue I could imagine is that
> you need to manipulate the time of return. But we can do that in the GUI, so
> I assume it should be possible.

We should investigate the side effects, for instance AddReturn will test if the item can be checked in, whereas MarkIssueReturned will (almost only) move the entry from issues to old_issues.
Comment 5 Katrin Fischer 2022-03-30 16:13:22 UTC
(In reply to Jonathan Druart from comment #4)
> (In reply to Katrin Fischer from comment #3)
> > Jonathan, do you think the fix would be to use AddReturn? 
> > 
> > I haven't checked yet, but I think the only issue I could imagine is that
> > you need to manipulate the time of return. But we can do that in the GUI, so
> > I assume it should be possible.
> 
> We should investigate the side effects, for instance AddReturn will test if
> the item can be checked in, whereas MarkIssueReturned will (almost only)
> move the entry from issues to old_issues.

I think for the offline circulation it's important that the item is _always_ returned, because it's in the library already, so you have to deal with it somehow. 

Maybe something like a "force" parameter?
Comment 6 Katrin Fischer 2022-04-21 19:18:26 UTC
*** Bug 25977 has been marked as a duplicate of this bug. ***