Bug 21523

Summary:	Switch two-column templates to Bootstrap grid: Serials part 2
Product:	Koha	Reporter:	Owen Leonard <oleonard>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	martin.renvoize, nick, testopia
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:
Bug Blocks:	20654, 21505, 21511
Attachments:	Bug 21523: Update two-column templates with Bootstrap grid: Serials part 2 Bug 21523: Update two-column templates with Bootstrap grid: Serials part 2 Bug 21523: Update two-column templates with Bootstrap grid: Serials part 2

Description Owen Leonard 2018-10-09 15:52:01 UTC

These two-column serials templates can be updated to use the Bootstrap grid.

 - modules/serials/serials-home.tt
 - modules/serials/serials-search.tt
 - modules/serials/subscription-detail.tt
 - modules/serials/subscription-frequencies.tt
 - modules/serials/subscription-history.tt
 - modules/serials/subscription-numberpatterns.tt
 - modules/serials/viewalerts.tt

Comment 1 Owen Leonard 2018-10-09 16:46:12 UTC

Created attachment 80296 [details] [review]
Bug 21523: Update two-column templates with Bootstrap grid: Serials part 2

This patch modifies several serials templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Serials home page
   - Subscription search
     - Subscription details
       - Edit history (under the "Planning" tab. Manual history must be
         enabled for that subscription).
       - Subscribers
 - Serials -> Manage frequencies
 - Serials -> Manage numbering patterns

Comment 2 Claire Gravely 2018-10-11 09:39:14 UTC

Created attachment 80390 [details] [review]
Bug 21523: Update two-column templates with Bootstrap grid: Serials part 2

This patch modifies several serials templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Serials home page
   - Subscription search
     - Subscription details
       - Edit history (under the "Planning" tab. Manual history must be
         enabled for that subscription).
       - Subscribers
 - Serials -> Manage frequencies
 - Serials -> Manage numbering patterns

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Comment 3 Katrin Fischer 2018-10-11 20:07:27 UTC

Created attachment 80422 [details] [review]
Bug 21523: Update two-column templates with Bootstrap grid: Serials part 2

This patch modifies several serials templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Serials home page
   - Subscription search
     - Subscription details
       - Edit history (under the "Planning" tab. Manual history must be
         enabled for that subscription).
       - Subscribers
 - Serials -> Manage frequencies
 - Serials -> Manage numbering patterns

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Nick Clemens (kidclamp) 2018-10-19 17:40:03 UTC

Awesome work all!

Pushed to master for 18.11

Comment 5 Martin Renvoize (ashimema) 2018-11-05 17:02:25 UTC

The enhancement will not be backported to 18.05.x series.