Summary: | overdue_notices.pl aborting because error is not caught | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | Notices | Assignee: | Colin Campbell <colin.campbell> |
Status: | RESOLVED WORKSFORME | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | hayleypelham, josef.moravec, martin.renvoize, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: | Patch to test a valid object returned |
Description
Colin Campbell
2018-10-10 10:42:58 UTC
Created attachment 80326 [details] [review] Patch to test a valid object returned Adds a run-time test to ensure the assumption of the following code is true. Without the patch process aborts on call to branchemail method. With patch applied if find fails to return a valid library we skip to the next and issue an error listing the problematic branchcode As we dont live in the "best of all possible worlds" code should be more pessimistic and test for unexpected results (In reply to Colin Campbell from comment #1) > Created attachment 80326 [details] [review] [review] > Patch to test a valid object returned > > Adds a run-time test to ensure the assumption of the following code is true. > Without the patch process aborts on call to branchemail method. > > With patch applied if find fails to return a valid library we skip to the > next and issue an error listing the problematic branchcode > > As we dont live in the "best of all possible worlds" code should be more > pessimistic and test for unexpected results Hi, is there some test plan for this patch? Hi Colin, I'm wondering if this situation will have been helped by the fix for bug 22679 - thoughts? I'm marking this Failed QA because comment 2 and comment 3 need to be addressed before this can be signed off. Pretty sure this is caught at this point.. either way I'm closing and we can open a fresh bug when we spot it in the wild. |