Summary: | Subscription "New fields" button should read "New field" | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize, nick, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 21519 | ||
Bug Blocks: | |||
Attachments: |
Bug 21531: Subscription "New fields" button should read "New field"
Bug 21531: Subscription "New fields" button should read "New field" Bug 21531: Subscription "New fields" button should read "New field" |
Description
Owen Leonard
2018-10-10 11:59:18 UTC
Created attachment 80336 [details] [review] Bug 21531: Subscription "New fields" button should read "New field" This patch changes the label of the "New fields" button on the subscription add fields page to read "New field," making it consistent with similar buttons in the staff client. Also changed: - Add missing id to <select> to make label clickable. - Remove custom DataTables configuration in favor of defaults. To test, apply the patch and go to Serials -> Add subscription fields. - The button in the toolbar should read "New field." - The DataTables' functionality of the table of existing custom fields should be correct. - Click the "New field" button. - Cliking the "Authorised value category" label should put the focus on the dropdown. Created attachment 80399 [details] [review] Bug 21531: Subscription "New fields" button should read "New field" This patch changes the label of the "New fields" button on the subscription add fields page to read "New field," making it consistent with similar buttons in the staff client. Also changed: - Add missing id to <select> to make label clickable. - Remove custom DataTables configuration in favor of defaults. To test, apply the patch and go to Serials -> Add subscription fields. - The button in the toolbar should read "New field." - The DataTables' functionality of the table of existing custom fields should be correct. - Click the "New field" button. - Cliking the "Authorised value category" label should put the focus on the dropdown. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 80421 [details] [review] Bug 21531: Subscription "New fields" button should read "New field" This patch changes the label of the "New fields" button on the subscription add fields page to read "New field," making it consistent with similar buttons in the staff client. Also changed: - Add missing id to <select> to make label clickable. - Remove custom DataTables configuration in favor of defaults. To test, apply the patch and go to Serials -> Add subscription fields. - The button in the toolbar should read "New field." - The DataTables' functionality of the table of existing custom fields should be correct. - Click the "New field" button. - Cliking the "Authorised value category" label should put the focus on the dropdown. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.06 I prefer to avoid changing display of 17.11.x |