Summary: | Anonymize function in Patron should not scramble email addresses | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Patrons | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, jose-mario.monteiro-santos, kyle.m.hall, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.05.00
|
|
Circulation function: | |||
Bug Depends on: | 21336 | ||
Bug Blocks: | |||
Attachments: |
Bug 21535: Anonymize function in Patron should not scramble email addresses
Bug 21535: Anonymize function in Patron should not scramble email addresses Bug 21535: Anonymize function in Patron should not scramble email addresses |
Description
Marcel de Rooy
2018-10-10 13:31:11 UTC
Created attachment 80349 [details] [review] Bug 21535: Anonymize function in Patron should not scramble email addresses Scrambled email addresses will only generate warnings etc. Clear them although they might be in BorrowerMandatoryField. Test plan: Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Could not apply patch 80349 - Bug 21535: Anonymize function in Patron should not scramble email addresses Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21535: Anonymize function in Patron should not scramble email addresses fatal: sha1 information is lacking or useless (Koha/Patron.pm). error: could not build fake ancestor Patch failed at 0001 Bug 21535: Anonymize function in Patron should not scramble email addresses The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21535-Anonymize-function-in-Patron-should-not--A7pXsa.patch TODO flgAnonymized has been renamed Created attachment 88906 [details] [review] Bug 21535: Anonymize function in Patron should not scramble email addresses Scrambled email addresses will only generate warnings etc. Clear them although they might be in BorrowerMandatoryField. Test plan: Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> t/db_depepended/Koha/Patrons.t runs with no warnings. Created attachment 89162 [details] [review] Bug 21535: Anonymize function in Patron should not scramble email addresses Scrambled email addresses will only generate warnings etc. Clear them although they might be in BorrowerMandatoryField. Test plan: Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> t/db_depepended/Koha/Patrons.t runs with no warnings. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> No regressions found. Passing QA Thx Owen and Martin ! Awesome work all! Pushed to master for 19.05 Dependency not in 18.11.x series. |