Bug 21536

Summary: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled
Product: Koha Reporter: Mirko Tietgen <mirko>
Component: Test SuiteAssignee: Mirko Tietgen <mirko>
Status: CLOSED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: martin.renvoize, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 17602    
Bug Blocks:    
Attachments: Bug 21536: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled
Bug 21536: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled
Bug 21536: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled

Description Mirko Tietgen 2018-10-10 14:15:42 UTC
t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled if WebService::ILS is not available.
Comment 1 Mirko Tietgen 2018-10-10 14:18:31 UTC
Created attachment 80353 [details] [review]
Bug 21536: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled

t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled
if WebService::ILS is not available.
Comment 2 Mirko Tietgen 2018-10-10 14:26:01 UTC
Test plan:
- have a system without Webservice::ILS available
- in koha-shell, do 
  prove t/Koha_ExternalContent_RecordedBooks.t
- tests should be skipped and tests count as "passed"
Comment 3 Jonathan Druart 2018-10-12 13:34:50 UTC
Created attachment 80476 [details] [review]
Bug 21536: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled

t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled
if WebService::ILS is not available.

Test plan:
- have a system without Webservice::ILS available
- in koha-shell, do
  prove t/Koha_ExternalContent_RecordedBooks.t
- tests should be skipped and tests count as "passed"

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Martin Renvoize 2018-10-12 14:11:37 UTC
Created attachment 80502 [details] [review]
Bug 21536: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled

t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled
if WebService::ILS is not available.

Test plan:
- have a system without Webservice::ILS available
- in koha-shell, do
  prove t/Koha_ExternalContent_RecordedBooks.t
- tests should be skipped and tests count as "passed"

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2018-10-12 14:12:03 UTC
Trivial patch, works as expected. Passing QA.
Comment 6 Tomás Cohen Arazi 2018-10-12 18:36:24 UTC
Pushed for 18.11. Thanks all!
Comment 7 Martin Renvoize 2018-10-15 17:18:59 UTC
Caused by bug 17602 not in 18.05.x series.