Summary: | OverDrive password submission should use a password field to mask input | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Web services | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 21082 | ||
Bug Blocks: | |||
Attachments: |
Bug 21542: Use modal and password field for overdrive password
Bug 21542: Use modal and password field for overdrive password |
Description
Nick Clemens (kidclamp)
2018-10-10 15:56:22 UTC
Created attachment 80364 [details] [review] Bug 21542: Use modal and password field for overdrive password To test: 1 - Enabled Overdrive and fill all preferences 2 - Make sure OverDrivePasswordRequired is true 3 - Go to opac account 4 - Log in to overdrive 5 - Note the input is shown 6 - Apply patch 7 - Repeat 8 - Note popup is now a modal 9 - Note password is now hidden 10 - Confirm overdrive integration works as before Sorry dude, QA Script doesn't like you: FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/overdrive-login.inc FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 1) My bad... this is an OPAC patch.. false fail. Created attachment 80597 [details] [review] Bug 21542: Use modal and password field for overdrive password To test: 1 - Enabled Overdrive and fill all preferences 2 - Make sure OverDrivePasswordRequired is true 3 - Go to opac account 4 - Log in to overdrive 5 - Note the input is shown 6 - Apply patch 7 - Repeat 8 - Note popup is now a modal 9 - Note password is now hidden 10 - Confirm overdrive integration works as before Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial patch so moving straight to Passed QA (especially as it's really just a followup for bug 21082) Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.06 |