Description
Katrin Fischer
2018-10-10 22:24:13 UTC
Created attachment 83376 [details] [review] Bug 21545: Translate 'Stock rotation slip' Throwing in some capitalization fixes for the English version of the notice as well. To test: - Verify the changes make sense and the SQL is still valid and executes Created attachment 83377 [details] [review] Bug 21545: Translate new ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF notices to German To test: - Apply patch - Run the German web installer - Verify the sample notices installs without error - Verify it looks 'German' in the GUI :) Created attachment 87749 [details] [review] Bug 21545: Translate new ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF notices to German To test: - Apply patch - Run the German web installer - Verify the sample notices installs without error - Verify it looks 'German' in the GUI :) Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> (In reply to Katrin Fischer from comment #2) > Created attachment 83376 [details] [review] [review] > Bug 21545: Translate 'Stock rotation slip' > > Throwing in some capitalization fixes for the English > version of the notice as well. > > To test: > - Verify the changes make sense and the SQL is still valid > and executes Couldn't figure out how to amend this commit, but I followed the test plan for it so please consider both patches signed off! Hi Hayley, thx a lot for testing! There are some tricks to make sighing off multiple patches super easy: https://wiki.koha-community.org/wiki/Tips_and_tricks In my devbox it's git so2 2 (sign-off last 2 patches, without running tests) (In reply to Katrin Fischer from comment #6) > Hi Hayley, thx a lot for testing! > > There are some tricks to make sighing off multiple patches super easy: > https://wiki.koha-community.org/wiki/Tips_and_tricks > > In my devbox it's git so2 2 (sign-off last 2 patches, without running tests) Thank you very much Katrin, that's very useful! Created attachment 88023 [details] [review] Bug 21545: Translate 'Stock rotation slip' Throwing in some capitalization fixes for the English version of the notice as well. To test: - Verify the changes make sense and the SQL is still valid and executes Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 88024 [details] [review] Bug 21545: Translate new ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF notices to German To test: - Apply patch - Run the German web installer - Verify the sample notices installs without error - Verify it looks 'German' in the GUI :) Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Simple translation fix.. works for me.. Passing QA Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.05 |