Bug 21545

Summary: Update German web Installer for 18.11
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Installation and upgrade (web-based installer)Assignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: minor    
Priority: P5 - low CC: chris, gmcharlt, hayleypelham, martin.renvoize, nick
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22024
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.05.00, 18.11.05
Attachments: Bug 21545: Translate 'Stock rotation slip'
Bug 21545: Translate new ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF notices to German
Bug 21545: Translate new ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF notices to German
Bug 21545: Translate 'Stock rotation slip'
Bug 21545: Translate new ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF notices to German

Description Katrin Fischer 2018-10-10 22:24:13 UTC
The same procedure as every release...check sample files for missing values and translations.
Comment 1 Katrin Fischer 2018-12-18 22:33:18 UTC
Splitting rules added by bug 22024
Comment 2 Katrin Fischer 2018-12-18 23:37:22 UTC
Created attachment 83376 [details] [review]
Bug 21545: Translate 'Stock rotation slip'

Throwing in some capitalization fixes for the English
version of the notice as well.

To test:
- Verify the changes make sense and the SQL is still valid
  and executes
Comment 3 Katrin Fischer 2018-12-18 23:38:03 UTC
Created attachment 83377 [details] [review]
Bug 21545: Translate new ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF notices to German

To test:
- Apply patch
- Run the German web installer
- Verify the sample notices installs without error
- Verify it looks 'German' in the GUI :)
Comment 4 Hayley Pelham 2019-04-11 05:34:50 UTC
Created attachment 87749 [details] [review]
Bug 21545: Translate new ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF notices to German

To test:
- Apply patch
- Run the German web installer
- Verify the sample notices installs without error
- Verify it looks 'German' in the GUI :)

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Comment 5 Hayley Pelham 2019-04-11 05:40:06 UTC
(In reply to Katrin Fischer from comment #2)
> Created attachment 83376 [details] [review] [review]
> Bug 21545: Translate 'Stock rotation slip'
> 
> Throwing in some capitalization fixes for the English
> version of the notice as well.
> 
> To test:
> - Verify the changes make sense and the SQL is still valid
>   and executes

Couldn't figure out how to amend this commit, but I followed the test plan for it so please consider both patches signed off!
Comment 6 Katrin Fischer 2019-04-11 08:36:02 UTC
Hi Hayley, thx a lot for testing!

There are some tricks to make sighing off multiple patches super easy:
https://wiki.koha-community.org/wiki/Tips_and_tricks

In my devbox it's git so2 2 (sign-off last 2 patches, without running tests)
Comment 7 Hayley Pelham 2019-04-11 20:36:49 UTC
(In reply to Katrin Fischer from comment #6)
> Hi Hayley, thx a lot for testing!
> 
> There are some tricks to make sighing off multiple patches super easy:
> https://wiki.koha-community.org/wiki/Tips_and_tricks
> 
> In my devbox it's git so2 2 (sign-off last 2 patches, without running tests)

Thank you very much Katrin, that's very useful!
Comment 8 Martin Renvoize 2019-04-15 15:58:49 UTC
Created attachment 88023 [details] [review]
Bug 21545: Translate 'Stock rotation slip'

Throwing in some capitalization fixes for the English
version of the notice as well.

To test:
- Verify the changes make sense and the SQL is still valid
  and executes

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Martin Renvoize 2019-04-15 15:58:52 UTC
Created attachment 88024 [details] [review]
Bug 21545: Translate new ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF notices to German

To test:
- Apply patch
- Run the German web installer
- Verify the sample notices installs without error
- Verify it looks 'German' in the GUI :)

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Martin Renvoize 2019-04-15 15:59:23 UTC
Simple translation fix.. works for me.. Passing QA
Comment 11 Nick Clemens 2019-04-18 12:06:40 UTC
Awesome work all!

Pushed to master for 19.05
Comment 12 Martin Renvoize 2019-04-26 14:01:15 UTC
Pushed to 18.11.x for 18.11.05