Summary: | RoutingListNote should use raw filter and display HTML unescaped | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Serials | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | colin.campbell, fridolin.somers, martin.renvoize, nick, pierre-marc.thibault |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 21552: Use raw filter for displaying RoutingListNote
Bug 21552: Use raw filter for displaying RoutingListNote Bug 21552: Use raw filter for displaying RoutingListNote |
Description
Katrin Fischer
2018-10-11 19:54:40 UTC
Created attachment 80437 [details] [review] Bug 21552: Use raw filter for displaying RoutingListNote The RoutingListNote system preference works like other prefs allowing you to insert your own content on the routling list template using HTML. The default text even uses HTML, so it looks broken without this patch. To test: - Add a subscription - Add a new routing list to it - Add some patrons to it - Save - preview routing list - Verify that the note shows and is formatted correctly. I put some custom html in the RoutingListNote preference and looked at the preview. It does not seem there is a problem in the first place as there are no html nodes in the preview I opened by clicking "Save and preview routing slip". Am I missing a step? Hi Pierre-Marc, on master it shows for me: To change this note edit <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=RoutingListNote#jumped">RoutingListNote</a> system preference. So the HTML shows unrendered. Can you check if you have the patch applied already and what you put into the preference? Hi Katrin, I can confirm that the patch has not been applied. In the reference, I decided to insert the message you see on master : To change this note edit <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=RoutingListNote#jumped">RoutingListNote</a> system preference. and what I see is : To change this note edit RoutingListNote system preference. I don't know why, but I don't have a problem on my side. Do you know why the current code is not working correctly? I have no idea as it really should not work as there is a html filter on the element in master. :( Are you on recent master? Sorry Katrin, I took the wrong tab to do my tests. I shall corrige this immediately and sign off this ASAP I confirm the validity of your patch. :) Created attachment 80564 [details] [review] Bug 21552: Use raw filter for displaying RoutingListNote The RoutingListNote system preference works like other prefs allowing you to insert your own content on the routling list template using HTML. The default text even uses HTML, so it looks broken without this patch. To test: - Add a subscription - Add a new routing list to it - Add some patrons to it - Save - preview routing list - Verify that the note shows and is formatted correctly. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Hopefully this makes up my mistake. The problem was here and the patch fixes it. Thx! you had me a little worried there :) Created attachment 80645 [details] [review] Bug 21552: Use raw filter for displaying RoutingListNote The RoutingListNote system preference works like other prefs allowing you to insert your own content on the routling list template using HTML. The default text even uses HTML, so it looks broken without this patch. To test: - Add a subscription - Add a new routing list to it - Add some patrons to it - Save - preview routing list - Verify that the note shows and is formatted correctly. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.06 This is not needed for 17.11.x because generalroutingnote is not html filtered. |