Summary: | Add more spans with classes around callnumbers in OPAC for additional styling | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | OPAC | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21764 | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 21568: Add more spans with classes around callnumbers in OPAC for additional styling
Bug 21568: Add more spans with classes around callnumbers in OPAC for additional styling Bug 21568: Add more spans with classes around callnumbers in OPAC for additional styling |
Description
Kyle M Hall (khall)
2018-10-15 10:36:34 UTC
Created attachment 80588 [details] [review] Bug 21568: Add more spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. This was started on bug 21340 but I have found more callnumbers in the search results that need spans. Test Plan: 1) Apply this patch 2) Search for something in the OAPC with multiple results 3) View the HTML source 4) Note the new spans around the callnumbers, like: <span class="CallNumber" Created attachment 80589 [details] [review] Bug 21568: Add more spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. This was started on bug 21340 but I have found more callnumbers in the search results that need spans. Test Plan: 1) Apply this patch 2) Search for something in the OAPC with multiple results 3) View the HTML source 4) Note the new spans around the callnumbers, like: <span class="CallNumber" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 80865 [details] [review] Bug 21568: Add more spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. This was started on bug 21340 but I have found more callnumbers in the search results that need spans. Test Plan: 1) Apply this patch 2) Search for something in the OAPC with multiple results 3) View the HTML source 4) Note the new spans around the callnumbers, like: <span class="CallNumber" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Awesome work all! Pushed to master for 18.11 Enhancement, will not be backported into 18.05.x series. |