Bug 21589

Summary: Series link formed from 830 field is incorrect
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: OPACAssignee: Kyle M Hall (khall) <kyle>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: major    
Priority: P5 - low CC: ephetteplace, kyle, lucas, m.de.rooy, margaret, martin.renvoize, nick, phil, pierre-marc.thibault
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.05.00, 18.11.05
Circulation function:
Bug Depends on: 13692    
Bug Blocks:    
Attachments: Bug 21589: Series link formed from 830 field is incorrect
Sample records
Bug 21589: (follow-up) Close initial foreach loop
Bug 21589: Series link formed from 830 field is incorrect
Bug 21589: Series link formed from 830 field is incorrect
Bug 21589: Series link formed from 830 field is incorrect

Description Nick Clemens (kidclamp) 2018-10-17 18:37:46 UTC
Bug 13692 corrected the series link for records using a 490/800 combination

When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank)
Comment 1 Kyle M Hall (khall) 2018-10-17 18:44:41 UTC
Created attachment 80750 [details] [review]
Bug 21589: Series link formed from 830 field is incorrect

Bug 13692 corrected the series link for records using a 490/800 combination

When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank)

Test Plan:
1) Catalog two or more records with 830 fields
2) Note the series links are broken
3) Apply this patch
4) Reload the record details page
5) The series link should now work
Comment 2 Pierre-Marc Thibault 2018-10-19 20:49:21 UTC
When I apply the patch and refresh the record detail page, the detail disappears the next moment.
Comment 3 Phil Ringnalda 2018-10-25 00:54:19 UTC
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl is also affected, since bug 13692 also changed it.
Comment 4 Nick Clemens (kidclamp) 2018-11-13 14:31:13 UTC
Created attachment 82275 [details]
Sample records
Comment 5 Nick Clemens (kidclamp) 2018-11-26 18:41:08 UTC
Created attachment 82654 [details] [review]
Bug 21589: (follow-up) Close initial foreach loop
Comment 6 Owen Leonard 2018-12-05 16:09:37 UTC
(In reply to Phil Ringnalda from comment #3)
> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl is also
> affected, since bug 13692 also changed it.

I agree that the OPAC should be addressed by this bug too.
Comment 7 Nick Clemens (kidclamp) 2019-04-24 00:38:43 UTC
Created attachment 88582 [details] [review]
Bug 21589: Series link formed from 830 field is incorrect

Bug 13692 corrected the series link for records using a 490/800 combination

When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank)

Test Plan:
1) Catalog two or more records with 830 fields
2) Note the series links are broken
3) Apply this patch
4) Reload the record details page
5) The series link should now work
6) Repeat for the OPAC
Comment 8 Claire Gravely 2019-04-25 09:32:04 UTC
Created attachment 88734 [details] [review]
Bug 21589: Series link formed from 830 field is incorrect

Bug 13692 corrected the series link for records using a 490/800 combination

When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank)

Test Plan:
1) Catalog two or more records with 830 fields
2) Note the series links are broken
3) Apply this patch
4) Reload the record details page
5) The series link should now work
6) Repeat for the OPAC

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 9 Marcel de Rooy 2019-04-26 06:27:25 UTC
QA: Looking here
Comment 10 Marcel de Rooy 2019-04-26 06:42:11 UTC
Created attachment 88849 [details] [review]
Bug 21589: Series link formed from 830 field is incorrect

Bug 13692 corrected the series link for records using a 490/800 combination

When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank)

Test Plan:
1) Catalog two or more records with 830 fields
2) Note the series links are broken
3) Apply this patch
4) Reload the record details page
5) The series link should now work
6) Repeat for the OPAC

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 11 Nick Clemens (kidclamp) 2019-04-26 12:40:51 UTC
Awesome work all!

Pushed to master for 19.05
Comment 12 Martin Renvoize (ashimema) 2019-04-26 15:55:07 UTC
Pushed to 18.11.x for 18.11.05
Comment 13 Lucas Gass (lukeg) 2019-05-24 16:24:59 UTC
backported to 18.05.x for 18.05.13