| Summary: | Remove Group by clause in GetAuthValueDropbox | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Alex Buckley <alexbuckley> |
| Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 21597 | ||
| Attachments: |
Bug 21593: Remove GROUP BY from GetAuthValueDropbox
Bug 21593: Remove GROUP BY from GetAuthValueDropbox |
||
|
Description
Alex Buckley
2018-10-18 04:57:47 UTC
Created attachment 80800 [details] [review] Bug 21593: Remove GROUP BY from GetAuthValueDropbox With new MYSQL modes we are permitted only full group by. In this case I don't think we need a GROUP BY at all To test: 1 - Try to pay a fine or create a borrower 2 - Internal server error 3 - Apply patch 4 - Page should load 5 - Test various authorised values ot ensure they work e.g. Set bsort1 and bsort2 to have some authorised values with and without branch limits set PAYMENT_TYPE to have some values with and without branch limits This looks sane and the code scans.. Trivial change and I can't see any reason we would need the group_by clause here. I'm running through the whole test suite to check for any fallout but then I think it's a 'straight to QA' candidate. Created attachment 80803 [details] [review] Bug 21593: Remove GROUP BY from GetAuthValueDropbox With new MYSQL modes we are permitted only full group by. In this case I don't think we need a GROUP BY at all To test: 1 - Try to pay a fine or create a borrower 2 - Internal server error 3 - Apply patch 4 - Page should load 5 - Test various authorised values ot ensure they work e.g. Set bsort1 and bsort2 to have some authorised values with and without branch limits set PAYMENT_TYPE to have some values with and without branch limits Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Tests pass, QA script pass, test plan pass. Passing QA ok for me, I had the same fix.
However I noted:
Hum This one is weird, I have no idea why there is a group by lib here.
This patch will introduce a change in behaviour /!\
If several AV have the same description they will not all be displayed in the dropdown list.
But it seems like a bug fix, otherwise only 1 will be display, but the user
will not know that there are two different codes
Pushed to master for 18.11 Pushed to 18.05.x for 18.05.06 I prefer not change behaviour in oldstable 17.11.x |