Summary: | Koha::Account::Line->apply should store credit offsets as negative amounts | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | jonathan.druart, kyle, martin.renvoize, nick, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 20997 | ||
Bug Blocks: | 13098, 21646, 22837 | ||
Attachments: |
Bug 21607: Make Koha::Account::Line->apply store credits as negative amounts
Bug 21607: Make Koha::Account::Line->apply store credits as negative amounts Bug 21607: Make Koha::Account::Line->apply store credits as negative amounts Bug 21621: Remove incorrect GROUP BY from tools/letter.pl |
Description
Tomás Cohen Arazi (tcohen)
2018-10-18 14:38:46 UTC
Created attachment 80858 [details] [review] Bug 21607: Make Koha::Account::Line->apply store credits as negative amounts This is a trivial patch, that makes offsets have 'amount' stored as negative values for applied credits. The behaviour is changed on the tests and adjusted in the code. To test: - Run $ kshell k$ prove t/db_dependent/Koha/Account/Lines.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 80874 [details] [review] Bug 21607: Make Koha::Account::Line->apply store credits as negative amounts This is a trivial patch, that makes offsets have 'amount' stored as negative values for applied credits. The behaviour is changed on the tests and adjusted in the code. To test: - Run $ kshell k$ prove t/db_dependent/Koha/Account/Lines.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Michal Denar <black23@gmail.com> Created attachment 80938 [details] [review] Bug 21607: Make Koha::Account::Line->apply store credits as negative amounts This is a trivial patch, that makes offsets have 'amount' stored as negative values for applied credits. The behaviour is changed on the tests and adjusted in the code. To test: - Run $ kshell k$ prove t/db_dependent/Koha/Account/Lines.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I concur.. passing qa Awesome work all! Pushed to master for 18.11 Created attachment 80948 [details] [review] Bug 21621: Remove incorrect GROUP BY from tools/letter.pl Fix: 'koha_kohadev.letter.name' isn't in GROUP BY DBD::mysql::db selectall_arrayref failed: 'koha_kohadev.letter.name' isn't in GROUP BY [for Statement "SELECT branchcode, module, code, name, branchname FROM letter LEFT OUTER JOIN branches USING (branchcode) GROUP BY branchcode,module,code ORDER BY module, code, branchcode"] at /home/vagrant/kohaclone/tools/letter.pl line 383. Test plan: - Copy some default notice templates for specific libraries - List the different notice templates - Confirm that notices appear only one, with "all libraries" you will see all Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Looks like this went to the wrong bug Pierre ;) Bug not present in 18.05.x series. |