Summary: | Tax hints should not be abbreviated | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Acquisitions | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, jonathan.druart, martin.renvoize, nick, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 21387 | ||
Bug Blocks: | 22225 | ||
Attachments: |
Bug 21619: Expand tax abreviations in acquisitions form hints
Bug 21619: Expand tax abreviations in acquisitions form hints Bug 21619: Expand tax abreviations in acquisitions form hints |
Description
Martin Renvoize (ashimema)
2018-10-19 11:45:14 UTC
To clarify, this is about 'tax inc.' and 'tax exc.'. My question is.. should the replacement be `before tax` and `after tax` `tax included` and `tax excluded` `tax inclusive` and `tac exclusive` They're all technically correct. Created attachment 80929 [details] [review] Bug 21619: Expand tax abreviations in acquisitions form hints I tested it and it works fine. However, since it depends on bug 21387 (which currently has failed qa status), I'm not sure if I can/should mark it as signed off. Tax hints on both ordering and receiving forms are now long form. This does not affect the tables. Created attachment 81919 [details] [review] Bug 21619: Expand tax abreviations in acquisitions form hints Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Created attachment 82000 [details] [review] Bug 21619: Expand tax abreviations in acquisitions form hints Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.06 Depends on Bug 21387 not in 17.11.x |