| Summary: | Incorrect GROUP BY in tools/letter.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize, nick, pierre-marc.thibault |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 17258, 22002 | ||
| Attachments: |
Bug 21621: Remove incorrect GROUP BY from tools/letter.pl
Bug 21621: Remove incorrect GROUP BY from tools/letter.pl Bug 21621: Remove incorrect GROUP BY from tools/letter.pl |
||
Created attachment 80942 [details] [review] Bug 21621: Remove incorrect GROUP BY from tools/letter.pl Fix: 'koha_kohadev.letter.name' isn't in GROUP BY DBD::mysql::db selectall_arrayref failed: 'koha_kohadev.letter.name' isn't in GROUP BY [for Statement "SELECT branchcode, module, code, name, branchname FROM letter LEFT OUTER JOIN branches USING (branchcode) GROUP BY branchcode,module,code ORDER BY module, code, branchcode"] at /home/vagrant/kohaclone/tools/letter.pl line 383. Test plan: - Copy some default notice templates for specific libraries - List the different notice templates - Confirm that notices appear only one, with "all libraries" you will see all Created attachment 80949 [details] [review] Bug 21621: Remove incorrect GROUP BY from tools/letter.pl Fix: 'koha_kohadev.letter.name' isn't in GROUP BY DBD::mysql::db selectall_arrayref failed: 'koha_kohadev.letter.name' isn't in GROUP BY [for Statement "SELECT branchcode, module, code, name, branchname FROM letter LEFT OUTER JOIN branches USING (branchcode) GROUP BY branchcode,module,code ORDER BY module, code, branchcode"] at /home/vagrant/kohaclone/tools/letter.pl line 383. Test plan: - Copy some default notice templates for specific libraries - List the different notice templates - Confirm that notices appear only one, with "all libraries" you will see all Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Created attachment 81366 [details] [review] Bug 21621: Remove incorrect GROUP BY from tools/letter.pl Fix: 'koha_kohadev.letter.name' isn't in GROUP BY DBD::mysql::db selectall_arrayref failed: 'koha_kohadev.letter.name' isn't in GROUP BY [for Statement "SELECT branchcode, module, code, name, branchname FROM letter LEFT OUTER JOIN branches USING (branchcode) GROUP BY branchcode,module,code ORDER BY module, code, branchcode"] at /home/vagrant/kohaclone/tools/letter.pl line 383. Test plan: - Copy some default notice templates for specific libraries - List the different notice templates - Confirm that notices appear only one, with "all libraries" you will see all Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.06 I pass for sql modes in 17.11.x |
DBD::mysql::db selectall_arrayref failed: 'koha_kohadev.letter.name' isn't in GROUP BY [for Statement "SELECT branchcode, module, code, name, branchname FROM letter LEFT OUTER JOIN branches USING (branchcode) GROUP BY branchcode,module,code ORDER BY module, code, branchcode"] at /home/vagrant/kohaclone/tools/letter.pl line 383.