Bug 21631

Summary: No warning when placing a hold with current location/pick-up location combination forbidden by Transport cost matrix
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: Hold requestsAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: andreas.jonsson, andrew, fiona.borthwick, gmcharlt, philippe.blouin
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Caroline Cyr La Rose 2018-10-22 16:03:56 UTC
I might be missing a setting here, holds are so complicated and have so many settings... Plus this is in a multi-branch system situation...

I was expecting to see an error or a warning for holds with a combination of current location and pick-up location that is forbidden by transport cost matrix.

To reproduce:
0) Make sure you have several branches in your system (at least 3, I'll call them A, B and C)
1) Go to Administration > Global system preferences and activate UseTransportCostMatrix
2) Go to Administration > Transport cost matrix
3) Click on the cell for the combination 'From A to B', uncheck 'Disable' and enter 0
4) Leave combination 'From A to C' disabled
5) In the catalog, search for an item which is currently at library A and currently available (you can use item search for this)
6) Place a hold for this item and change the pick-up location to library B
7) Run misc/cronjobs/holds/build_holds_queue.pl
8) Go to Circulation > Holds queue
9) Choose library A, item should be in the queue
10) In the catalog, search for an item which is currently at library A and currently available (you can use item search for this)
11) Place a hold for this item and change the pick-up location to library C (there is no warning, everything seems fine)
12) Run misc/cronjobs/holds/build_holds_queue.pl
13) Go to Circulation > Holds queue
14) Choose library A, 2nd item is not in the queue

Am I missing something?
Comment 1 Andrew Fuerste-Henry 2020-07-23 15:26:12 UTC
+1 on this
If the transport cost matrix makes a hold unfillable, we should only allow staff to place it with an override and should block patrons from placing it at all on the OPAC.