Bug 21634

Summary:	"Circulation" option is lost when viewing patron's logs
Product:	Koha	Reporter:	Jonathan Druart <jonathan.druart>
Component:	Patrons	Assignee:	Jonathan Druart <jonathan.druart>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	fridolin.somers, gmcharlt, kyle.m.hall, martin.renvoize, nick, pierre-marc.thibault
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:
Bug Blocks:	21242
Attachments:	Bug 21634: Keep "circulation" module selected when viewing patron's logs Bug 21634: Keep "circulation" module selected when viewing patron's logs Bug 21634: Keep "circulation" module selected when viewing patron's logs Bug 21634: Keep "circulation" module selected when viewing patron's logs

Description Jonathan Druart 2018-10-23 13:14:14 UTC

To recreate:
- View a patron detail page
- Click "Modification log"
- Notice that the url has "modules=MEMBERS&amp;modules=circulation", but the "Circulation" option is not selected in the "Modules" dropdown list.
This is because of uppercase vs lowercase.

The bug:
- Right after you click "Modification log" you will see all the "members" and "circulation" logs
- Submit the form without changing any input/select from the form
=> Now you only see the "members" logs.

Comment 1 Jonathan Druart 2018-10-23 13:17:32 UTC

Created attachment 81023 [details] [review]
Bug 21634: Keep "circulation" module selected when viewing patron's logs

To recreate:
- View a patron detail page
- Click "Modification log"
- Notice that the url has "modules=MEMBERS&amp;modules=circulation", but
the "Circulation" option is not selected in the "Modules" dropdown list.
This is because of uppercase vs lowercase.

The bug:
- Right after you click "Modification log" you will see all the
"members" and "circulation" logs
- Submit the form without changing any input/select from the form
=> Now you only see the "members" logs.

Test plan:
- Apply the patch
- Click "Modification log"
- Notice that the url now contains "modules=MEMBERS&amp;modules=CIRCULATION"
- Submit the form without changing any input/select from the form
=> Now you have the "members" and "circulation" modules selected.

Comment 2 Pierre-Marc Thibault 2018-10-26 19:01:03 UTC

There is a conflict when the patch is applied. A rebase is necessary.

Comment 3 Jonathan Druart 2018-10-26 19:08:42 UTC

Created attachment 81335 [details] [review]
Bug 21634: Keep "circulation" module selected when viewing patron's logs

To recreate:
- View a patron detail page
- Click "Modification log"
- Notice that the url has "modules=MEMBERS&amp;modules=circulation", but
the "Circulation" option is not selected in the "Modules" dropdown list.
This is because of uppercase vs lowercase.

The bug:
- Right after you click "Modification log" you will see all the
"members" and "circulation" logs
- Submit the form without changing any input/select from the form
=> Now you only see the "members" logs.

Test plan:
- Apply the patch
- Click "Modification log"
- Notice that the url now contains "modules=MEMBERS&amp;modules=CIRCULATION"
- Submit the form without changing any input/select from the form
=> Now you have the "members" and "circulation" modules selected.

Comment 4 Pierre-Marc Thibault 2018-10-26 19:23:33 UTC

Created attachment 81336 [details] [review]
Bug 21634: Keep "circulation" module selected when viewing patron's logs

To recreate:
- View a patron detail page
- Click "Modification log"
- Notice that the url has "modules=MEMBERS&amp;modules=circulation", but
the "Circulation" option is not selected in the "Modules" dropdown list.
This is because of uppercase vs lowercase.

The bug:
- Right after you click "Modification log" you will see all the
"members" and "circulation" logs
- Submit the form without changing any input/select from the form
=> Now you only see the "members" logs.

Test plan:
- Apply the patch
- Click "Modification log"
- Notice that the url now contains "modules=MEMBERS&amp;modules=CIRCULATION"
- Submit the form without changing any input/select from the form
=> Now you have the "members" and "circulation" modules selected.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>

Comment 5 Katrin Fischer 2018-10-28 11:52:52 UTC

Created attachment 81401 [details] [review]
Bug 21634: Keep "circulation" module selected when viewing patron's logs

To recreate:
- View a patron detail page
- Click "Modification log"
- Notice that the url has "modules=MEMBERS&amp;modules=circulation", but
the "Circulation" option is not selected in the "Modules" dropdown list.
This is because of uppercase vs lowercase.

The bug:
- Right after you click "Modification log" you will see all the
"members" and "circulation" logs
- Submit the form without changing any input/select from the form
=> Now you only see the "members" logs.

Test plan:
- Apply the patch
- Click "Modification log"
- Notice that the url now contains "modules=MEMBERS&amp;modules=CIRCULATION"
- Submit the form without changing any input/select from the form
=> Now you have the "members" and "circulation" modules selected.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 6 Nick Clemens (kidclamp) 2018-10-29 01:20:08 UTC

Awesome work all!

Pushed to master for 18.11

Comment 7 Martin Renvoize (ashimema) 2018-11-08 15:50:40 UTC

Pushed to 18.05.x for 18.05.06

Comment 8 Fridolin Somers 2018-11-28 12:43:49 UTC

Pushed to 17.11.x for 17.11.13