Summary: | Clean up SRU fields mapping templates | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | martin.renvoize, mtompset, nick, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 19436 | ||
Bug Blocks: | 20654 | ||
Attachments: |
Bug 21647: Clean up SRU fields mapping templates
Bug 21647: Clean up SRU fields mapping templates Bug 21647: Clean up SRU fields mapping templates Bug 21647: Clean up SRU fields mapping templates |
Description
Owen Leonard
2018-10-24 15:03:55 UTC
Created attachment 81076 [details] [review] Bug 21647: Clean up SRU fields mapping templates This patch makes corrections to the SRU field mapping templates (bibliographic and authority): - Bootstrap grid - JavaScript to the footer - Other markup corrections To test, apply the patch and go to Administration -> Z39.50/SRU servers - Add or edit an SRU server - Click "Modify" next to the SRU search fields mapping field. - Confirm that the popup window layout is correct. - Confirm that adding information to the form is correctly saved to the SRU server form. - Test this process with SRU server record type set to both "Authority" and "Bibliographic." For authorities, these unexplained errors happen in validation. Error: End tag div seen, but there were open elements. From line 122, column 5; to line 122, column 10 form>↩ </div>↩↩↩↩↩↩ Error: Unclosed element main. From line 62, column 5; to line 62, column 10 id">↩↩ <main>↩ Error: Stray end tag div. From line 129, column 9; to line 129, column 14 ↩↩ </div>↩↩ Created attachment 81132 [details] [review] Bug 21647: Clean up SRU fields mapping templates This patch makes corrections to the SRU field mapping templates (bibliographic and authority): - Bootstrap grid - JavaScript to the footer - Other markup corrections To test, apply the patch and go to Administration -> Z39.50/SRU servers - Add or edit an SRU server - Click "Modify" next to the SRU search fields mapping field. - Confirm that the popup window layout is correct. - Confirm that adding information to the form is correctly saved to the SRU server form. - Test this process with SRU server record type set to both "Authority" and "Bibliographic." Created attachment 81341 [details] [review] Bug 21647: Clean up SRU fields mapping templates This patch makes corrections to the SRU field mapping templates (bibliographic and authority): - Bootstrap grid - JavaScript to the footer - Other markup corrections To test, apply the patch and go to Administration -> Z39.50/SRU servers - Add or edit an SRU server - Click "Modify" next to the SRU search fields mapping field. - Confirm that the popup window layout is correct. - Confirm that adding information to the form is correctly saved to the SRU server form. - Test this process with SRU server record type set to both "Authority" and "Bibliographic." Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Created attachment 81365 [details] [review] Bug 21647: Clean up SRU fields mapping templates This patch makes corrections to the SRU field mapping templates (bibliographic and authority): - Bootstrap grid - JavaScript to the footer - Other markup corrections To test, apply the patch and go to Administration -> Z39.50/SRU servers - Add or edit an SRU server - Click "Modify" next to the SRU search fields mapping field. - Confirm that the popup window layout is correct. - Confirm that adding information to the form is correctly saved to the SRU server form. - Test this process with SRU server record type set to both "Authority" and "Bibliographic." Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 Enhancement, will not be backported to 18.05.x series. |