Summary: | C4::Items::GetLastAcquisitions has never been used and should be removed | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | martin.renvoize, mtompset, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 21650: Remove the subroutine C4::Items::GetLastAcquisitions
Bug 21650: Remove the subroutine C4::Items::GetLastAcquisitions Bug 21650: Remove the subroutine C4::Items::GetLastAcquisitions Bug 21659: Change link to basket group edit page |
Description
Jonathan Druart
2018-10-24 18:29:15 UTC
Created attachment 81082 [details] [review] Bug 21650: Remove the subroutine C4::Items::GetLastAcquisitions C4::Items::GetLastAcquisitions has been added by commit 7753bbad4fb4df47c8fb4f959fc68764a71cb623 Adding Some new functions (?) Apparently it has never been used, we should remove it to avoid unnecessary maintenance. Test plan: git grep GetLastAcquisitions must not return any results POD Coverage failure. Otherwise Ok. Created attachment 81083 [details] [review] Bug 21650: Remove the subroutine C4::Items::GetLastAcquisitions C4::Items::GetLastAcquisitions has been added by commit 7753bbad4fb4df47c8fb4f959fc68764a71cb623 Adding Some new functions (?) Apparently it has never been used, we should remove it to avoid unnecessary maintenance. Test plan: git grep GetLastAcquisitions must not return any results NOTE: POD Coverage test failure is expected on removal Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 81291 [details] [review] Bug 21650: Remove the subroutine C4::Items::GetLastAcquisitions C4::Items::GetLastAcquisitions has been added by commit 7753bbad4fb4df47c8fb4f959fc68764a71cb623 Adding Some new functions (?) Apparently it has never been used, we should remove it to avoid unnecessary maintenance. Test plan: git grep GetLastAcquisitions must not return any results NOTE: POD Coverage test failure is expected on removal Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 Enhancement, will not be backported to 18.05.x series. Created attachment 87398 [details] [review] Bug 21659: Change link to basket group edit page I have taken another look at other links like the one from acq order search and changed the link to not lead to the vendor's basket group page but to the edit page of the invidividual basket group. To test: - Same as first patch, verify links now lead to the basket grou edit page Comment on attachment 87398 [details] [review] Bug 21659: Change link to basket group edit page Wrong bug number! |