Bug 21669

Summary: TT assignment statements must not be html filtered
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: katrin.fischer, m.de.rooy, martin.renvoize, nick
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Medium patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 13618, 21663    
Bug Blocks:    
Attachments: Bug 21669: Do not html filter TT assignement statements
Bug 21669: Do not html filter TT assignement statements
[PASSED QA] Bug 21669: Do not html filter TT assignement statements

Description Jonathan Druart 2018-10-25 16:06:11 UTC

    
Comment 1 Jonathan Druart 2018-10-25 16:20:43 UTC
Created attachment 81184 [details] [review]
Bug 21669: Do not html filter TT assignement statements

Why? Because we must filter the variables when we display them.
If we escape them on assignement, they will be double escaped:
  [% XXX = "<span>pouet</span>" | html %]
  [% XXX | html %]
  => &lt;span&gt;pouet&lt;/span&gt;

Also it will bring trouble if we are assigning a structure (see bug
21663 for instance).
Comment 2 Jonathan Druart 2018-10-25 16:21:50 UTC
No test plan here, too many changes.

- Eyeball the patch
- Are the changes make sense?
Comment 3 Owen Leonard 2018-10-25 17:52:41 UTC
Created attachment 81191 [details] [review]
Bug 21669: Do not html filter TT assignement statements

Why? Because we must filter the variables when we display them.
If we escape them on assignement, they will be double escaped:
  [% XXX = "<span>pouet</span>" | html %]
  [% XXX | html %]
  => &lt;span&gt;pouet&lt;/span&gt;

Also it will bring trouble if we are assigning a structure (see bug
21663 for instance).

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Marcel de Rooy 2018-10-26 09:31:01 UTC
fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Comment 5 Jonathan Druart 2018-10-26 12:12:30 UTC
Please apply first:
Bug 13618: Remove html filter for LAST
Bug 21663: Incorrect filter prevents predefined notes from being added to patron acccounts


I thought they would have been pushed quickly.
Comment 6 Katrin Fischer 2018-10-26 13:28:03 UTC
Even with the bugs mentioned I can't get past:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 21669: Do not html filter TT assignement statements
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt).
error: could not build fake ancestor
Comment 7 Katrin Fischer 2018-10-26 13:36:41 UTC
Created attachment 81289 [details] [review]
[PASSED QA] Bug 21669: Do not html filter TT assignement statements

Why? Because we must filter the variables when we display them.
If we escape them on assignement, they will be double escaped:
  [% XXX = "<span>pouet</span>" | html %]
  [% XXX | html %]
  => &lt;span&gt;pouet&lt;/span&gt;

Also it will bring trouble if we are assigning a structure (see bug
21663 for instance).

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Nick Clemens (kidclamp) 2018-10-26 17:25:19 UTC
Awesome work all!

Pushed to master for 18.11
Comment 9 Martin Renvoize 2018-11-06 13:24:57 UTC
Caused by bug 13618 not in 18.05.x series.