Summary: | Koha/Patron/Modifications.t is failing randomly | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | lucas, m.de.rooy, martin.renvoize, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.05.00, 18.11.06, 18.05.13
|
|
Bug Depends on: | |||
Bug Blocks: | 25551 | ||
Attachments: |
Bug 21671: Prevent Modifications.t to fail randomly
Bug 21671: Prevent Modifications.t to fail randomly Bug 21671: Prevent Modifications.t to fail randomly |
Description
Jonathan Druart
2018-10-25 17:39:11 UTC
Same today on 18.05_U18 (#112) Created attachment 82238 [details] [review] Bug 21671: Prevent Modifications.t to fail randomly If repeatable is set to 0 by TestBuilder, the tests will fail with: t/db_dependent/Koha/Patron/Modifications.t .. 1/6 # Looks like you planned 20 tests but ran 9. # Failed test 'approve tests' # at t/db_dependent/Koha/Patron/Modifications.t line 259. [repeatable not set for attribute type and tried to add a new attribute for the same code]# Looks like your test exited with 255 just after 5. Created attachment 89038 [details] [review] Bug 21671: Prevent Modifications.t to fail randomly If repeatable is set to 0 by TestBuilder, the tests will fail with: t/db_dependent/Koha/Patron/Modifications.t .. 1/6 # Looks like you planned 20 tests but ran 9. # Failed test 'approve tests' # at t/db_dependent/Koha/Patron/Modifications.t line 259. [repeatable not set for attribute type and tried to add a new attribute for the same code]# Looks like your test exited with 255 just after 5. Signed-off-by: Liz Rea <wizzyrea@gmail.com> I couldn't get the test to fail, but it still passes with this change and if Jonathan thinks it needs it, it probably does. Created attachment 89300 [details] [review] Bug 21671: Prevent Modifications.t to fail randomly If repeatable is set to 0 by TestBuilder, the tests will fail with: t/db_dependent/Koha/Patron/Modifications.t .. 1/6 # Looks like you planned 20 tests but ran 9. # Failed test 'approve tests' # at t/db_dependent/Koha/Patron/Modifications.t line 259. [repeatable not set for attribute type and tried to add a new attribute for the same code]# Looks like your test exited with 255 just after 5. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.06 backported to 18.05.x for 18.05.13 |