Summary: | Remove dead code C4::Accounts::fixaccounts | ||
---|---|---|---|
Product: | Koha | Reporter: | Josef Moravec <josef.moravec> |
Component: | Architecture, internals, and plumbing | Assignee: | Josef Moravec <josef.moravec> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 14825 | ||
Attachments: |
Bug 21680: Remove dead code - C4::Accounts::fixaccounts
Bug 21680: Remove dead code - C4::Accounts::fixaccounts |
Description
Josef Moravec
2018-10-26 09:26:53 UTC
Created attachment 81259 [details] [review] Bug 21680: Remove dead code - C4::Accounts::fixaccounts Test plan: git grep fixacccounts -- without patch there are 3 occurences -- with patch - no occurence of fixaccounts Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 81295 [details] [review] Bug 21680: Remove dead code - C4::Accounts::fixaccounts Test plan: git grep fixacccounts -- without patch there are 3 occurences -- with patch - no occurence of fixaccounts Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Well found.. you are entirely right, I can't find a single case across the whole codebase where this is used now. Going straight for PQA. Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.06.. always good to trim the fat. I prefer not to impact 17.11.x |